Prepare for shared-script-properties removal #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpv is about to remove `shared-script-properties`, which will cause `utils.shared_script_property_set` to be nil. Check for it's existence before calling it.
|
Yes, however we should wait for mpv-player/mpv#12456 to be merged. |
|
I was going to wait until shared-script-properties was actually removed, but it looks like it might take a while and I don't want to forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpv is about to remove
shared-script-properties, which will causeutils.shared_script_property_setto be nil.Check for it's existence before calling it.
Ref mpv-player/mpv#12456