Api/v1.7.0 #117
Merged
Api/v1.7.0 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CogentRedTester
force-pushed
the
API/v1.7.0
branch
from
4dbb585 to
cabeba3
Compare
This uses the new coroutine.queue method. Note that this does subtly change the behaviour of directory scanning; scanning now always occurs asynchronously even if all of the parsers are synchronous.
This allows for optional API version checking to be added to custom keybinds, which have been implicitly relying on the addon API for some time.
This should pre-empt any problems with 2-digit version numbers.
The cache now stores the state values in a weak table. A history array and a travertsal stack are used to lock some directories into the cache.
CogentRedTester
added a commit
that referenced
this pull request
Jan 15, 2025
This should never have been here, addons should need to explicitly provide a version number.
CogentRedTester
added a commit
that referenced
this pull request
Jan 15, 2025
CogentRedTester
added a commit
that referenced
this pull request
Jan 15, 2025
`mp.input` is now bound to `input`, and `mpv-user-input` is bound to `user_input`.
CogentRedTester
force-pushed
the
API/v1.7.0
branch
from
ddd9616 to
7877e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionfield toapi_versionto reduce confusion.version.api_versionfield.api_versionfield to keybinds to unify the APIs (started in API v1.5.0 #80).Resolves #95