Implement directory mapping API feature #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allows for mappings to be created between paths. The intention is that this can be used to resolve external paths to a cannonical location within file-browser's file tree. Upcoming commits will implement this translation at key points where paths are received from external sources.
CogentRedTester
changed the title
This may be reverted in the future depending on how the mappings are used.
For now mappings will not be added to the documented addon API due to the experimental nature of the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows for mappings to be created between an external path, and a path within file-browser's file tree. It is intended to allow external paths to be resolved to a single canonical location within the file tree.
The only use of this feature within file-browser is to resolve the
bd://,dvd://, andcdda://paths to their respective device paths.This feature may be added as a documented part of the addon API, but is currently experimental. The name of the feature may also change.
Before being merged the specific locations where a mapping is converted into it's canonical path should be documented.