Skip to content

Update FreeplayState.hx #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2025
Merged

Conversation

NebulaStellaNova
Copy link
Contributor

No description provided.

@crowplexus crowplexus added the status:awaiting Awaiting response by creator of issue label Jul 2, 2025
@crowplexus
Copy link
Member

why though?

@NexIsDumb
Copy link
Member

there was a reason why the parsed field is there, and reason is to avoid running that on update everytime, why are you changing that?

@TechnikTil
Copy link
Contributor

If parsedColor and FlxColor.fromString(color) are the same thing, just parsedColor is parsed beforehand, why is this needed exactly?

@ItsLJcool
Copy link
Contributor

ItsLJcool commented Jul 2, 2025

uh I believe parsedColor was used because no one thought about just parsing it with FlxColor and it was ease of use. tbh idek why it existed lmao

in this case, if we merge this pr we would need to replace parsedColor, and its only purpouse was to save the result into the instance, It was also noted to not even export to the json but to just be a data holder
image

@NexIsDumb
Copy link
Member

wait lemme check smth

@NexIsDumb
Copy link
Member

nnope, its better not to merge this since everytime the meta loads parsedcolor gets used automatic
its just a way to reduce calculus and optimise
immagine

...buuuuutt, you gave me an idea, its really annoying indeed have two values, so why not making color already an FlxColor?
IT COULD break few scripts but imo its really worth it

@NexIsDumb NexIsDumb added status:accepted This has been solved successfully and removed status:awaiting Awaiting response by creator of issue labels Jul 4, 2025
@NexIsDumb NexIsDumb marked this pull request as draft July 4, 2025 20:30
@NexIsDumb
Copy link
Member

i'll work on it rn

@NexIsDumb
Copy link
Member

it should be good

@NexIsDumb NexIsDumb marked this pull request as ready for review July 4, 2025 23:03
@NexIsDumb NexIsDumb merged commit 7a8f1f0 into CodenameCrew:main Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted This has been solved successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants