London | May 2025 | Houssam Lahlah | Acoursework/sprint 3 #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle, and last names.
…om file path string using slice.
…ween minimum and maximum.
Added comments to exclude instructional lines from execution.
Updated age variable to let to allow incrementing its value
Declare variable before using in template string.
Add comments explaining slice error and fix by converting number to string
…umerator cases and add stretch scenarios for isProperFraction edge case testing
…id cards and throw error for invalid ones
…e cards; throw error for invalid cards
- Return proper suffixes for 1st, 2nd, 3rd, and others (e.g., 4th, 11th, 23rd) - Added Jest tests for various edge cases including teens (11th-13th) - Improved function to handle general inputs dynamically
- Added str and count parameters to repeat function - Used String.repeat to repeat str count times - Throws error if count is negative - Added tests for count = 1, 0, and negative values
…iled comments and explanations
LonMcGregor
reviewed
Jul 23, 2025
There was a problem hiding this comment.
Good work on this sprint. To answer your questions: In a larger function you would want to split the code up to make it easier to read and more maintainable, but I think the file in this sprint is small enough that it doesn't matter so much. Your repeat function is fine. You can close this PR now.
| @@ -8,7 +8,9 @@ | |||
| // write one test at a time, and make it pass, build your solution up methodically | |||
|
|
|||
| function isProperFraction(numerator, denominator) { | |||
| // Use absolute value of numerator to handle negatives | |||
| if (numerator < denominator) return true; | |||
There was a problem hiding this comment.
I can see from your later implementation in section 2 you got this right. If you made changes, remember to copy them over
LonMcGregor
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implemented getOrdinalNumber, repeat, countChar functions with tests
Completed credit card validator with all validation rules
Completed password validator basic structure (to be improved for full requirements)
Added comments to explain logic and decisions in each file
Questions
For the password validator, should we include all rules in one function or break them into smaller helper functions for readability?
Can you confirm if my approach for repeat() with error handling on negative count is acceptable?