Skip to content

London | May 2025 | Samuel Tarawally | Sprint 3 | Coursework #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

London | May 2025 | Samuel Tarawally | Sprint 3 | Coursework #669

wants to merge 19 commits into from

Conversation

Tarawally
Copy link

@Tarawally Tarawally commented Jul 19, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • key implement: core functions, basic assertions
  • mandatory rewrite: Jest tests
  • mandatory practice/implement: practice functions, Jest tests

Tarawally added 17 commits July 14, 2025 23:41
@Tarawally
ignores local vscode configurations
46d1dd2
@Tarawally
feat(get-angle-type): Implement angle type detection and add assertions
322f47b
@Tarawally
feat(is-proper-fraction): Implement proper fraction check and add ass…
a605763 
…ertions
@Tarawally
feat(get-card-value): Implement card value retrieval and add assertions
b2b4431
@Tarawally
feat(get-angle-type): Complete getAngleType function
522a42d
@Tarawally
test(get-angle-type): Add Jest tests for angle type detection
8f48f05
@Tarawally
feat(is-proper-fraction): Complete isProperFraction function
824799f
@Tarawally
test(is-proper-fraction): Add Jest tests for proper fraction check
8d3de72
@Tarawally
feat(get-card-value): Complete getCardValue function
1b18cc3
@Tarawally
test(get-card-value): Add Jest tests for card value retrieval
f75bb27
@Tarawally
feat(count): Implement character counting function
1e6c96d
@Tarawally
test(count): Add Jest tests for character counting
825fb63
@Tarawally
feat(get-ordinal-number): Implement ordinal number conversion
b828e42
@Tarawally
test(get-ordinal-number): Add Jest tests for ordinal number conversion
ca00539
@Tarawally
feat(repeat): Implement string repetition function
45a420c
@Tarawally
test(repeat): Add Jest tests for string repetition
92a8fcb
@Tarawally
Merge branch 'CodeYourFuture:main' into sprint-3
23caf51
@Tarawally Tarawally linked an issue Jul 20, 2025 that may be closed by this pull request
02 Complete Sprint 3 coursework Tarawally/My-Coursework-Planner#20
Open
@Tarawally Tarawally added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 21, 2025
@Tarawally Tarawally marked this pull request as ready for review July 21, 2025 14:05
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 22, 2025
LonMcGregor
LonMcGregor reviewed Jul 22, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this - I have one small extra question for you to consider that could improve your code

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 22, 2025
@Tarawally Tarawally added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 22, 2025
@LonMcGregor
Copy link

Good work - you are complete with this sprint now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 22, 2025
@Tarawally Tarawally mentioned this pull request Jul 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LonMcGregor LonMcGregor LonMcGregor left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

02 Complete Sprint 3 coursework
2 participants
@Tarawally @LonMcGregor