-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Auto focus text field when creating new files and folders #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This looks great, just needs the lint fix and we can merge! |
|
@thecoolwinter Looks like just an unrelated issue with the |
|
I agree, I can't seem to track down why those tests are failing but they appear to be fixed on main. We can merge without those passing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one bug. If there's a file system event while the new file item is focused, it silently fails to create the file.
Description
When we create a new file or folder, CodeEdit will now automatically focus the renaming field so the user can directly set the file name in one step.
Files and folders are no longer created immediately, instead a "phantom" file will be represented in the project navigator, and will only actually create the file when the user sets a valid file name.
Lastly, we do not automatically set the file extension for the user.
Related Issues
Checklist
Screenshots
auto.rename.mov