Welcome Window Improvements#2040
Closed
austincondiff wants to merge 2 commits intoCodeEditApp:mainfrom
Closed
Conversation
…tion to fix bug when using plain window style. Focusing list by default so it is highlighted. Made welcome action symbols a bit smaller
Collaborator
Author
|
Note to self: I need to handle cmd W because this no longer closes the window, which is why tests fail. I also will need a better way to identify the welcome window to apply the shadow because sometimes it is not getting applied to the correct window. There is also an issue when opening a file or folder and it adds a new item to the recents list, where the list contents begin above the window’s top edge resulting in the top of the new item being cut off. It is fixed when scrolling at all. I assume the scroll view is miscalculating to scroll top position. |
Collaborator
Author
|
Closing. These changes were carried over to CodeEditWelcomeWindow, a new repo for our welcome window which will be implanted in a subsequent PR when completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following improvements to the Welcome window:
Note: There are several issues with the
.plainwindow style so we had to make the following workarounds:Checklist
Screenshots
Before

After
