Skip to content

Welcome Window Improvements #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented May 8, 2025

Description

This PR makes the following improvements to the Welcome window:

  • Changed window style to be consistent with Xcode's
  • Made welcome action symbols a bit smaller
  • Fixed bug where removing recents via context menu was removing wrong items

Note: There are several issues with the .plain window style so we had to make the following workarounds:

  • Focusing list by default so it is highlighted
  • Handling keyboard navigation manually

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before
Screenshot 2025-05-07 at 11 57 03 PM

After
Screenshot 2025-05-07 at 11 54 05 PM

…tion to fix bug when using plain window style. Focusing list by default so it is highlighted. Made welcome action symbols a bit smaller
@austincondiff
Copy link
Collaborator Author

austincondiff commented May 8, 2025

Note to self: I need to handle cmd W because this no longer closes the window, which is why tests fail. I also will need a better way to identify the welcome window to apply the shadow because sometimes it is not getting applied to the correct window.

There is also an issue when opening a file or folder and it adds a new item to the recents list, where the list contents begin above the window’s top edge resulting in the top of the new item being cut off. It is fixed when scrolling at all. I assume the scroll view is miscalculating to scroll top position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant