Skip to content

Fix Find Navigator resizing delay, use line height from user settings #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FastestMolasses
Copy link
Member

@FastestMolasses FastestMolasses commented Apr 3, 2025

Description

Fixes the resizing delay when resizing the Find Navigator.
The Find Navigator now uses the "Find Navigator Detail" user setting to set how many lines to show per search result.

Related Issues

Closes #2017 #2016

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:

before.find.nav.mov

After:

after.find.nav.mov

@FastestMolasses FastestMolasses added bug Something isn't working enhancement New feature or request UI This is UI related navigator find labels Apr 3, 2025
@FastestMolasses FastestMolasses self-assigned this Apr 3, 2025
@austincondiff
Copy link
Collaborator

Where are we with this one?

@FastestMolasses
Copy link
Member Author

Ready for review!

@FastestMolasses FastestMolasses marked this pull request as ready for review May 12, 2025 20:05
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It seems like we should be doing this for all cells that wrap in any navigator and so it may be wise to make this more reusable at some point.

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This feels much smoother to use.
Does this close both #2017 and #2016, or just #2017?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request find navigator UI This is UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Find Navigator should use "Find Navigator Detail" setting
3 participants