Autocomplete Implementation #1949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
requested changes
Dec 23, 2024
| handleNotification(notification) | ||
| case let .error(error): | ||
| print("Error from EventStream for \(key.languageId.rawValue): \(error)") | ||
| } | ||
| } | ||
|
|
||
| private func handleRequest(_ request: ServerRequest) { |
There was a problem hiding this comment.
Lets leave this commented for now.
|
|
||
| /// Will query the language server for autocomplete suggestions and then display the window. | ||
| @MainActor | ||
| func showAutocompleteWindow() { |
There was a problem hiding this comment.
I mentioned it in the review of the CETV pr, but this function should be moved to CESE. That should simplify this type, as you could instead add a parameter to CESE for an optional ItemBoxDelegate, and ignore the unnecessary TextViewCoordinator conformance. Then make the ItemBoxDelegate pass the text controller when it inserts items so you can still make that range conversion on line 111.
That does make it a little harder to get this object down to be visible to the CodeFileView, but check how it works with the content coordinator. I tried to make it so it's extendable for new types like this.
- Add a published property to CodeFileDocument
- Extend the type in
LanguageServerFileMapto contain this object - When opening a document, set this object in the
CodeFileDocument's new published property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds first iteration of the autocomplete feature.
Related Issues
Checklist
Screenshots