Skip to content

fix(upload): drop the unused thumbnail upload - #560

Merged
YOGESH-08 merged 1 commit into
CodeChefVIT:stagingfrom
Dx-Alz-xD:krish/remove-upload-thumbnail
Nov 15, 2026
Merged

YOGESH-08 merged 1 commit into
CodeChefVIT:stagingfrom
Dx-Alz-xD:krish/remove-upload-thumbnail

Conversation

@Dx-Alz-xD

@Dx-Alz-xD Dx-Alz-xD commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

📌 Purpose

The upload page never sends a thumbnail, and when one was sent, the service passed the full PDF URL to uploadThumbnail, so the thumbnail was saved under an object literally named https://storage.googleapis.com/<bucket>/....png.


Corresponding issue: closes #553


🖼️ Showcase

no UI change atall Upload checks still return the same responses, and pnpm build passes.


🔧 Changes

  • Removed the thumbnail field from /api/upload, uploadPaper and src/lib/storage/gcp.ts
  • New papers are still saved with thumbnail_url: null, as before when no thumbnail was sent
  • Dropped thumbnail_url from the upload response type on the upload page (it was never read)

➕ Additional Notes

  • if thumbnails are needed later they should be saved next to the PDF (unapproved/<id>.png) using the object path rather than the URL

the upload page never sends a thumbnail, and when one was sent the
service passed the full pdf url to uploadThumbnail, so the object was
saved under a name like https://storage.googleapis.com/<bucket>/....png
remove the thumbnail field from the route, the service and gcp storage
@YOGESH-08

Copy link
Copy Markdown
Collaborator

Thank you for fixing this, lgtm

@YOGESH-08
YOGESH-08 merged commit 8f13034 into CodeChefVIT:staging Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/api/upload: thumbnail handling is unused and saves the file under the wrong name

2 participants