Skip to content

Cod 732 support perf profiling in python walltime #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Apr 16, 2025

Depends on: CodSpeedHQ/instrument-hooks#1 (must be merged and released before merging this)

@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch 3 times, most recently from 9d3b8cb to e6c7442 Compare April 22, 2025 16:16
@not-matthias not-matthias requested a review from art049 April 22, 2025 17:19
@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch from e6c7442 to a3717e4 Compare April 23, 2025 08:52
@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch 2 times, most recently from da53257 to 5330f3f Compare May 7, 2025 13:17
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting, curious to see if there is any performance changes, especially on the instrumentation results. Can you fix the CI to see the results?

@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch from 5330f3f to c2a1644 Compare May 8, 2025 16:30
@not-matthias not-matthias requested a review from art049 May 9, 2025 12:54
@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch 4 times, most recently from cb73581 to 650a49c Compare May 13, 2025 09:28
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much left, we're getting close :)

@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch 2 times, most recently from 648dc66 to 3bf2db5 Compare May 13, 2025 16:30
@not-matthias
Copy link
Member Author

not-matthias commented May 13, 2025

Currently still failing due to CodSpeedHQ/instrument-hooks#2, but should be good to go once merged. Lmk if the requested changes look good.

@not-matthias not-matthias requested a review from art049 May 13, 2025 17:57
Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Walltime Performance Report

Merging #79 will degrade performances by 26.95%

Comparing cod-732-support-perf-profiling-in-python-walltime (5dc6f3b) with master (c92304c)

Summary

⚡ 4 improvements
❌ 37 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 606.5 ns 808.6 ns -24.99%
test_make_allpass 4.6 µs 4.9 µs -7.13%
test_make_bandpass 4.8 µs 5.1 µs -6.16%
test_make_highpass 5 µs 5.3 µs -5.48%
test_make_highshelf 6.3 µs 6.6 µs -4.21%
test_make_lowpass 5.1 µs 5.3 µs -2.45%
test_make_lowshelf 6.5 µs 6.7 µs -2.53%
test_make_peak 5.7 µs 5.9 µs -3.02%
test_combination_lists[0-0] 1.6 µs 1.7 µs -7.16%
test_combination_lists[4-2] 3.5 µs 3.4 µs +3.48%
test_combination_lists[5-4] 3.1 µs 3.2 µs -3.45%
test_combination_sum[candidates0-8] 8.9 µs 9.3 µs -3.87%
test_depth_first_search[4] 27.9 µs 28.9 µs -3.65%
test_generate_all_combinations[0-0] 850.1 ns 957.7 ns -11.24%
test_generate_all_combinations[4-2] 5.6 µs 5.8 µs -3.55%
test_generate_all_combinations[5-4] 8 µs 8.4 µs -5.07%
test_generate_parenthesis[3] 7.4 µs 7.9 µs -6.89%
test_generate_sum_of_subsets_soln[nums0-9] 21.4 µs 20.5 µs +4.65%
test_get_valid_pos[pos0-4] 2.6 µs 2.7 µs -4.25%
test_hamilton_cycle[graph0] 23 µs 23.5 µs -2.14%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Instrumentation Performance Report

Merging #79 will degrade performances by 3.03%

Comparing cod-732-support-perf-profiling-in-python-walltime (5dc6f3b) with master (c92304c)

Summary

❌ 6 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iir_filter_process 31 µs 31.9 µs -2.59%
test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 15.6 µs 16.1 µs -3.01%
test_generate_all_combinations[0-0] 18.3 µs 18.8 µs -3.03%
test_noop_ellipsis_decorated 14.3 µs 14.6 µs -2.51%
test_noop_pass 12.3 µs 12.7 µs -2.67%
test_noop_pass_decorated 14.4 µs 14.7 µs -2.1%

@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch 3 times, most recently from cb2e48d to a3037b1 Compare May 14, 2025 16:53
@not-matthias not-matthias force-pushed the cod-732-support-perf-profiling-in-python-walltime branch 3 times, most recently from 583b977 to 5dc6f3b Compare May 14, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants