Skip to content

Use instrument hooks #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

GuillaumeLagrange
Copy link

No description provided.

@GuillaumeLagrange GuillaumeLagrange marked this pull request as draft July 18, 2025 08:41
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1163-add-instrument-hooks-to-codspeed-node branch 2 times, most recently from 79eed9c to 834ed04 Compare July 18, 2025 08:50
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1163-add-instrument-hooks-to-codspeed-node branch from 834ed04 to 11d48ea Compare July 18, 2025 09:45
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1163-add-instrument-hooks-to-codspeed-node branch from 11d48ea to 2a2de7a Compare July 18, 2025 10:03
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review July 18, 2025 10:07
Copy link

codspeed-hq bot commented Jul 18, 2025

CodSpeed Performance Report

Merging #45 will degrade performances by 36.16%

Comparing cod-1163-add-instrument-hooks-to-codspeed-node (0711f7e) with main (6df11e8)

Summary

⚡ 1 improvements
❌ 14 regressions
✅ 71 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
RegExp#test 14 µs 20.8 µs -32.41%
switch 1 11.9 µs 18.4 µs -35.41%
RegExp#test 14.2 µs 21.1 µs -32.66%
switch 1 11.9 µs 18.4 µs -35.15%
test_recursive_fibo_10 21.5 µs 28.2 µs -23.86%
test_recursive_fibo_10 40.3 µs 46.9 µs -14.02%
test_recursive_fibo_10 34.6 µs 41.3 µs -16.16%
test_recursive_fibo_10 40.4 µs 33.4 µs +20.94%
fibo 10 15.1 µs 21.7 µs -30.43%
RegExp#test 12.1 µs 19 µs -36.12%
switch 1 11.7 µs 18.3 µs -36.16%
RegExp#test 12.2 µs 19 µs -35.5%
switch 1 11.7 µs 18.2 µs -35.64%
RegExp#test 12.3 µs 19 µs -35.39%
switch 1 11.8 µs 18.2 µs -35.21%

@GuillaumeLagrange GuillaumeLagrange marked this pull request as draft July 18, 2025 10:13
@GuillaumeLagrange
Copy link
Author

@not-matthias I'm looking into performance regression I'll ping you when it's full ready sorry

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1163-add-instrument-hooks-to-codspeed-node branch from 2a2de7a to 0711f7e Compare July 21, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant