Open
Conversation
Fixes a crash that happens when a project is saved, if that project had an build phase exception set that's the child of a build phase that does not have a name. For example, the "Compile Sources" build phase does not have a name, and could lead to this crash.
sroyaura
reviewed
Oct 20, 2025
| else | ||
| build_phase.uuid | ||
| end | ||
| "Exceptions for \"#{GroupableHelper.parent(self).display_name}\" folder in \"#{build_phase_identifier}\" build phase" |
There was a problem hiding this comment.
I think this line can be removed? Currently it ends up in the pbxproj.
Author
There was a problem hiding this comment.
I can't remove it entirely, this function has to return some string.
This eventually goes into the comment in the pbxproj file that describes the exception set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash that happens when a project is saved, under the following conditions:
For example, the "Compile Sources" build phase does not have a name, and could lead to this crash if there's an exception set attached to it.
At some point during the saving of a project, The
display_namemethod of thePBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSettries to use thenameof the build phase, causing the crash.To fix this, I added a fallback behavior, if the build phase does not have a name, the UUID is used instead.
Example stacktrace of the issue this is solving: