Changed platform erosion to take cell arg and started parallelisation#171
Open
Changed platform erosion to take cell arg and started parallelisation#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the shore platform erosion logic to improve performance and thread safety, particularly in the context of parallel processing. The main change is to reduce repeated array lookups by passing a cell reference, and to make certain operations thread-safe when running in parallel with OpenMP.
Key improvements include:
Performance and Code Clarity:
DoActualPlatformErosionOnCellto accept aCGeomCell&reference, reducing repeated array lookups and improving code readability. All internal cell accesses now use this reference instead of repeated grid indexing. [1] [2] [3] [4] [5] [6] [7] [8]Parallelization and Thread Safety:
nDoAllShorePlatFormErosion, including reductions for relevant variables to safely accumulate results in parallel.Dependency and Header Updates:
cell.hand forward declaration forCGeomCellto support the new function signature and usage. [1] [2]