Skip to content

apache: create APACHE_RUN_DIR and APACHE_LOCK_DIR if they're defined#1158

Open
oalbrigt wants to merge 1 commit intoClusterLabs:mainfrom
oalbrigt:apache-run_dir-lock_dir-support
Open

apache: create APACHE_RUN_DIR and APACHE_LOCK_DIR if they're defined#1158
oalbrigt wants to merge 1 commit intoClusterLabs:mainfrom
oalbrigt:apache-run_dir-lock_dir-support

Conversation

@oalbrigt
Copy link
Copy Markdown
Contributor

@krig
Copy link
Copy Markdown
Contributor

krig commented Jun 15, 2018

LGTM

Comment thread heartbeat/apache Outdated
fi

if [ -n "${APACHE_LOCK_DIR}" ] && [ ! -d "${APACHE_LOCK_DIR}" ]; then
mkdir "${APACHE_LOCK_DIR}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also be mkdir -p?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I've pushed a new update to fix it.

@oalbrigt oalbrigt force-pushed the apache-run_dir-lock_dir-support branch from 8a4e49a to 3670a78 Compare June 15, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants