Fix wasm actions#151
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates several Rust crate dependencies to their latest versions, adjusts the getrandom feature for WebAssembly builds, and ensures the appropriate RUSTFLAGS are set in CI workflows.
- Upgrade core, CLI, WASM, and workspace crate versions (e.g.,
serde,wasm-bindgen,phf,colored,criterion). - Switch
getrandomfeature towasm_jsand addRUSTFLAGSfor WASM backends in test/build workflows. - Reformat the
mluadependency and bump its version.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wasm/Cargo.toml | Bumped serde, wasm-bindgen, updated clue_core features, switched getrandom to wasm_js. |
| core/Cargo.toml | Bumped phf, serde, serde_json, and criterion versions. |
| cli/Cargo.toml | Reformatted and bumped mlua dependency to v0.10.5. |
| Cargo.toml | Updated workspace dependency versions (ahash, clap, colored, etc.). |
| .github/workflows/test.yml | Added RUSTFLAGS: --cfg getrandom_backend="wasm_js" to WASM tests. |
| .github/workflows/build.yml | Added RUSTFLAGS: --cfg getrandom_backend="wasm_js" to WASM build. |
Comments suppressed due to low confidence (3)
wasm/Cargo.toml:20
- [nitpick] You removed
default-features = false, which may unintentionally enable default features fromclue_core. Consider re-addingdefault-features = falseif you only intend to enableserde.
clue_core = { path = "../core", version = "4.0.0-78ce10c1", features = [
Cargo.toml:20
- [nitpick] Upgrading
coloredfrom v2.x to v3.x is a major version bump and may include breaking changes. Verify that all calls to its API still compile and behave as expected.
colored = "3.0.0"
core/Cargo.toml:25
- [nitpick] Moving
criterionto v0.6.0 could introduce changes in benchmark configuration. Ensure your benchmark setup and CI reporting still work with the new version.
criterion = "0.6.0"
Rosy-iso
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.