This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 Integration
Properly supports all combinations and hybrid/mixed setups.
Issues found by @deepcode-ci-bot will be fixed after merge. |
derklaro
suggested changes
Sep 28, 2020
cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/network/NetworkConnection.java
Outdated
Show resolved
Hide resolved
cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/process/ProxyProcessData.java
Show resolved
Hide resolved
cloudnet-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/setup/SetupWrapper.java
Outdated
Show resolved
Hide resolved
TheMeinerLP
reviewed
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
...-api/cloudnet-api-bridge/src/main/java/eu/cloudnetservice/cloudnet/v2/bridge/CloudProxy.java
Outdated
Show resolved
Hide resolved
cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/network/NetworkConnection.java
Show resolved
Hide resolved
cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/process/ProxyProcessData.java
Show resolved
Hide resolved
cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/CloudNetWrapper.java
Outdated
Show resolved
Hide resolved
DeepCode's analysis on #e7a9fe found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Issues
======
+ Solved 5
- Added 2
Complexity increasing per file
==============================
- cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/server/BungeeCord.java 2
- cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/process/ProxyProcessData.java 2
Complexity decreasing per file
==============================
+ cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/CloudNetWrapperConfig.java -8
+ cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/server/ProxyProcessMeta.java -1
Clones removed
==============
+ cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/CloudNetWrapperConfig.java -1
+ cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/process/ProxyProcessData.java -1
See the complete overview on Codacy |
...net-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/bootstrap/CloudBootstrap.java
Show resolved
Hide resolved
...net-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/bootstrap/CloudBootstrap.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
Changes made to the repository:
This pull request changes part of the setup of the wrapper, allowing users to configure IPv6 and Dual Stack addresses (
0.0.0.0
).On top of that, the API was changed to properly support Internet Addresses instead of strings.
Documentation of test results:
Test results:
config.yml
:services.json
:config.yml
:Connections to the proxy in this configuration are able to be done over an internal IPv6 link.
Using
0.0.0.0
as theproxy-config-host
yields dual-stack capabilities, allowing IPv4 and IPv6 connections.Related issues/discussions:
This is a follow-up to #281.
Closes #275.