Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

IPv6 support #303

Merged
merged 18 commits into from
Oct 6, 2020
Merged

IPv6 support #303

merged 18 commits into from
Oct 6, 2020

Conversation

GiantTreeLP
Copy link
Member

@GiantTreeLP GiantTreeLP commented Aug 18, 2020

This pull request includes:

  • breaking changes (changed types and a changed method name)
  • no breaking changes

Changes made to the repository:

This pull request changes part of the setup of the wrapper, allowing users to configure IPv6 and Dual Stack addresses (0.0.0.0).
On top of that, the API was changed to properly support Internet Addresses instead of strings.

Documentation of test results:

Test results:

  • Configuration (only relevant parts):
    • Master:
      • config.yml:
        image
      • services.json:
        image
    • Wrapper:
      • config.yml:
        image

Connections to the proxy in this configuration are able to be done over an internal IPv6 link.
Using 0.0.0.0 as the proxy-config-host yields dual-stack capabilities, allowing IPv4 and IPv6 connections.

Related issues/discussions:

This is a follow-up to #281.
Closes #275.

@GiantTreeLP GiantTreeLP added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 18, 2020
@GiantTreeLP GiantTreeLP self-assigned this Aug 18, 2020
@GiantTreeLP GiantTreeLP marked this pull request as draft August 18, 2020 22:30
@GiantTreeLP GiantTreeLP changed the title 🚧:IPv6 support 🚧: IPv6 support Aug 20, 2020
@GiantTreeLP
Copy link
Member Author

Issues found by @deepcode-ci-bot will be fixed after merge.

@GiantTreeLP GiantTreeLP requested a review from a team September 28, 2020 16:46
Copy link
Contributor

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@ghost
Copy link

ghost commented Sep 28, 2020

DeepCode's analysis on #e7a9fe found:

  • ⚠️ 2 warnings, ℹ️ 3 minor issues. 👇

Top issues

Description Example fixes
Missing close on getInputStream leads to a resource leak. Occurrences: 🔧 Example fixes
Either rethrow this java.lang.InterruptedException or set the interrupted flag on the current thread with 'Thread.currentThread().interrupt()'. Otherwise the information that the current thread was interrupted will be lost. Occurrences: 🔧 Example fixes
Printing the stack trace of java.io.IOException. Production code should not use printStackTrace. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@GiantTreeLP GiantTreeLP marked this pull request as ready for review September 28, 2020 18:39
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5
- Added 2
           

Complexity increasing per file
==============================
- cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/server/BungeeCord.java  2
- cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/process/ProxyProcessData.java  2
         

Complexity decreasing per file
==============================
+ cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/CloudNetWrapperConfig.java  -8
+ cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/server/ProxyProcessMeta.java  -1
         

Clones removed
==============
+ cloudnet-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/CloudNetWrapperConfig.java  -1
+ cloudnet-lib/src/main/java/eu/cloudnetservice/cloudnet/v2/lib/process/ProxyProcessData.java  -1
         

See the complete overview on Codacy

@GiantTreeLP GiantTreeLP changed the title 🚧: IPv6 support IPv6 support Sep 28, 2020
@GiantTreeLP GiantTreeLP merged commit 4485fd4 into development Oct 6, 2020
@GiantTreeLP GiantTreeLP deleted the feature/ipv6 branch October 6, 2020 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants