Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check #present? of ActiveRecord objects because it's always true #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't check #present? of ActiveRecord objects because it's always true #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/closure_tree/hierarchy_maintenance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _ct_validate
if !(defined? @_ct_skip_cycle_detection) &&
!new_record? && # don't validate for cycles if we're a new record
changes[_ct.parent_column_name] && # don't validate for cycles if we didn't change our parent
parent.present? && # don't validate if we're root
parent && # don't validate if we're root
parent.self_and_ancestors.include?(self) # < this is expensive :\
errors.add(_ct.parent_column_sym, I18n.t('closure_tree.loop_error', default: 'You cannot add an ancestor as a descendant'))
end
Expand Down