New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JavaScript file extensions #1159

Open

RubenVerborgh wants to merge 1 commit into Clooos:main from RubenVerborgh:fix/js

RubenVerborgh commented Jan 19, 2025

Proposed change

Use .js file extensions, because this project does not use TypeScript.
- The current files are invalid TypeScript because of the imports.

Type of change

Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Example printscreens/gif

Additional information

Additional documentation needed.

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests screenshots/gifs have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for readme.


          Use JavaScript file extensions.

bc70917

Owner

Clooos commented Jan 19, 2025 •

edited

Loading

Hi! Indeed this make more sense, I've added .ts to keep the possibility for a switch in the future, but I'm still not sure I will, so... 🫣

Thank you so much for your help!

RubenVerborgh mentioned this pull request

Use CSS file extensions #1160

Open

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet