Added PR #1150 by @PhilPinsdorf

Adding live-update mode to Pop-Up Slider Headers fixing #1149
Clooos · Jan 21, 2025 · 10a736c · 10a736c
1 parent d9afda9
commit 10a736c
Show file tree

Hide file tree

Showing 2 changed files with 102 additions and 98 deletions.
diff --git a/dist/bubble-card.js b/dist/bubble-card.js
diff --git a/src/editor/bubble-card-editor.js b/src/editor/bubble-card-editor.js
@@ -780,18 +780,6 @@ class BubbleCardEditor extends LitElement {
                             ></ha-textfield>
                             ${this.makeDropdown("Optional - Icon", "icon")}
                             ${this.makeShowState()}
-                            <ha-formfield .label="Optional - Slider live update" style="display: ${this._button_type !== 'slider' ? 'none' : ''}">
-                                <ha-switch
-                                    aria-label="Optional - Slider live update"
-                                    .checked=${this._slider_live_update}
-                                    .configValue="${"slider_live_update"}"
-                                    @change=${this._valueChanged}
-                                ></ha-switch>
-                                <div class="mdc-form-field">
-                                    <label class="mdc-label">Optional - Slider live update</label> 
-                                </div>
-                            </ha-formfield>
-                            <ha-alert style="display: ${this._button_type !== 'slider' ? 'none' : ''}" alert-type="info">By default, sliders are updated only on release. You can toggle this option to enable live updates while sliding.</ha-alert>
                         </div>
                     </ha-expansion-panel>
                     <ha-expansion-panel outlined>
@@ -1650,6 +1638,20 @@ class BubbleCardEditor extends LitElement {
                     </div>
                 </ha-formfield>
             ` : ''}
+            ${array !== 'sub_button' && this._button_type === 'slider' ? html`
+                <ha-formfield .label="Optional - Slider live update">
+                    <ha-switch
+                        aria-label="Optional - Slider live update"
+                        .checked=${this._slider_live_update}
+                        .configValue="${"slider_live_update"}"
+                        @change=${this._valueChanged}
+                    ></ha-switch>
+                    <div class="mdc-form-field">
+                        <label class="mdc-label">Optional - Slider live update</label> 
+                    </div>
+                </ha-formfield>
+                <ha-alert alert-type="info">By default, sliders are updated only on release. You can toggle this option to enable live updates while sliding.</ha-alert>
+            ` : ''}
         `;
     }