-
Notifications
You must be signed in to change notification settings - Fork 51
Chromograph ideograms for hg38 #5883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| {name: '6', length: 346, cent_start: 125, cent_length: 13 }, | ||
| {name: '7', length: 321, cent_start: 125, cent_length: 10 }, | ||
| {name: '8', length: 293, cent_start: 98, cent_length: 8 }, // | ||
| {name: '8', length: 293, cent_start: 98, cent_length: 8 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a risk that these hardcoded values won't cut it for the hg38, but not much to do but test and adjust. 🤷♂️
|
Ideograms generated like |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5883 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 336 336
Lines 20960 20960
=======================================
Hits 17561 17561
Misses 3399 3399 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
northwestwitch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions. Just because I realised at the end that this PR was still a draft 😃
Co-authored-by: Chiara Rasi <[email protected]>
Co-authored-by: Chiara Rasi <[email protected]>
|
Ah sorry, I wanted to update this one but I marked it as ready for review |
|



This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stageand the server iscg-vm1.ssh <USER.NAME>@cg-vm1.scilifelab.sesudo -iu hiseq.clinicalssh localhostpodman pssystemctl --user stop scout@<name_of_currently_deployed_branch>systemctl --user start scout@<this_branch>systemctl --user status scout.targetscout-stage) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.seus; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browserbash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>us; scout --versionpaxaprocedure, which will release the allocated resource (scout-stage) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: