Fixes for issues #40, #38, #43, #42, #44, #45, #36 & #47 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up to avoid having to add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml when developers sets their own allowBackup value on their actual application
Changing ViewHolder visibility to public in order to support Kotlin applications
Refactor to Android X
Closed
Update to Api Level 29
Closed
vyguera
changed the title
Closed
vyguera
changed the title
vyguera
changed the title
vyguera
changed the title
vyguera
changed the title
added 2 commits
December 30, 2019 17:33
…does the library
vyguera
changed the title
vyguera
changed the title
vyguera
changed the title
This was referenced Dec 31, 2019
…hen any of notify* methods are called
vyguera
changed the title
|
Hello vyguera, Thanks for this pull request. Hope it's will be merged as soon as possible. Best regards, |
|
Hi Louis, Of course you can. Glad to read your proposal. Let me know about the public url if available as I'd like to switch to a repository in my projects, too. |
|
Hello vyguera, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues #40, #38, #43, #42, #44, #45, #36 & #47:
I made some cleaning up to avoid having to add 'tools:replace="android:allowBackup"' to element at AndroidManifest.xml when developers sets their own allowBackup value on their actual application
Also I refactored to Android X with Android Studio's refactoring tool, what also allowed me to upload API Level to 29. As a result, save button does not save to External Storage anymore, I had to save them in internal storage.
Besides sample didn't work on API Level 16. I've fixed this although images still won't be loaded as of some errors on Glide I cannot solve. Anyway not showing images are better than a crash.
Furthermore I fixed a crash when loading an Adapter with no data. This is no rows and/or no columns.
I fixed AdaptiveTableLayout.notifyDataSetChanged() too as it didn't refresh with new data.
I solved a problem when using any notify* method as top left corner wasn't changing.
Last but not least I made ViewHolder interface public to support Kotlin applications