Skip to content

Conversation

@TallPanda
Copy link
Contributor

@TallPanda TallPanda commented Oct 25, 2025

If this commit is applied, it will ....

Show versions above 0.G-19098-gb374081a98
EX:
cdda-0.I-2025-10-22-0304
cdda-experimental-2025-10-25-0651
cdda-0.H-2025-07-10-0402

Explain why this change is being made

Summary

None

Purpose of change

Version naming format looks to have changed pinning versions
presented on the main screen to 0.G-19098-gb374081a98,
as it was the last matching tag.

cmake:

cmake -S "$CDDA_SRC" -B build \
  -DCURSES=OFF \
  -DTILES=ON \
  -DSOUND=ON \
  -DLOCALIZE=ON \
  -DRELEASE=1 \
  -DDISABLE_WERROR=ON \
  -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
  -DCMAKE_CXX_FLAGS="-Wno-error -Wno-error=maybe-uninitialized"

# Build the tiles GUI
cmake --build build -j$(nproc)

Describe the solution

Updated the blob to look for tag starting with cdda-, this looks to be the new naming format.
Correct me if I have misunderstood this.

Describe alternatives you've considered

cdda-* looks to be appropriate,if the intention is to match both major and experimental releases

If only major releases are intended the following should fit:
cdda-[0-9].[A-Z]*

Testing

Ran the above cmake before and after changes on branches 0.H-branch and 0.I-branch
Version was seen to update from 0.G-19098-gb374081a98, to the appropriate version.

Additional context

0.I pre change
0 I pre change
0.I post change dirty
0 I post change
0.I post change cherrypicked
0 I post change

# If this commit is applied, it will ....
Show versions above 0.G-19098-gb374081a98
EG:

cdda-0.I-2025-10-22-0304
cdda-experimental-2025-10-25-0651
cdda-0.H-2025-07-10-0402

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|
Version naming format looks to have changed pinning versions 
presented on the main screen to 0.G-19098-gb374081a98,
as it was the last matching tag.

cdda-* looks to be appropriate,if the intention is to match both
major and experimental releases

If only major releases are intended the following should fit:
cdda-[0-9].[A-Z]*


# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments new contributor json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 25, 2025
@Maleclypse Maleclypse merged commit 93c6746 into CleverRaven:master Nov 1, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions new contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants