-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add flag for immunity to skin irritants #74680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Maleclypse
merged 12 commits into
CleverRaven:master
from
zachary-kaelan:bile-proof-flag
Jun 22, 2024
Merged
Add flag for immunity to skin irritants #74680
Maleclypse
merged 12 commits into
CleverRaven:master
from
zachary-kaelan:bile-proof-flag
Jun 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Maleclypse
reviewed
Jun 20, 2024
Maleclypse
reviewed
Jun 21, 2024
Maleclypse
reviewed
Jun 21, 2024
|
OK I still have some questions about some of these like patch skin and lupine fur but overall I think this makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Bionics
CBM (Compact Bionic Modules)
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Add IRRITANT_IMMUNE flag for describing immunity to skin irritants"
Purpose of change
When setting up an effect condition, I noted a significant number of potential mutations and mutation armors, and a few different armor suits, that could all reasonably provide total protection of the skin from irritating substances. The list in the effect condition was getting really long.
Describe the solution
Create a new flag,
IRRITANT_IMMUNE, and add it to anything that seems like it would either prevent irritating substances from making contact with the skin. or just remove the skin entirely. I based it on coverage, existing flags, and descriptions.Describe alternatives you've considered
Use the
ACID_IMMUNEflag instead. While a heavy coat of stiff fur would reasonably prevent a spray of itch powder from making contact with the skin, acid would burn straight through.Use the
WATERPROOFand/orRAINPROOFflags instead. While letting a few droplets of water slip between your glove and arm sleeves isn't worth fussing about (it will just evaporate), any amount of itching powder slipping through would suck, and it would find its way over a lot of the rest of your body as you're swinging weapons and ducking and weaving and such.Testing
The JSON style checker will yell at me if something is goofed.
Additional context
This is just for "all-or-nothing" things that cover basically all the skin on the body. More nuanced calculations will presumably come in #72271.