Skip to content

other: move cpu and memory settings over#2064

Merged
ClementTsang merged 5 commits into
mainfrom
config_migrations_p3
May 16, 2026
Merged

other: move cpu and memory settings over#2064
ClementTsang merged 5 commits into
mainfrom
config_migrations_p3

Conversation

@ClementTsang

@ClementTsang ClementTsang commented May 14, 2026

Copy link
Copy Markdown
Owner

Description

A description of the change, what it does, and why it was made. If relevant (e.g. UI changes), please also provide screenshots/recordings:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested (including steps):

If this change affects the program, please also indicate which platforms were tested:

  • Windows
  • macOS (specify version below)
  • Linux (specify distro below)
  • Other (specify below)

Checklist

Ensure all of these are met:

  • If this PR adds or changes a dependency, please justify this in the description
  • If this is a code change, areas your change affects have been linted using (cargo fmt)
  • If this is a code change, your changes pass cargo clippy --all -- -D warnings
  • If this is a code change, new tests were added if relevant
  • If this is a code change, your changes pass cargo test
  • The change has been tested to work (see above) and doesn't appear to break other things
  • Documentation has been updated if needed (README.md, help menu, docs, configs, etc.)
  • There are no merge conflicts
  • You have reviewed your changes first
  • The pull request passes the provided CI pipeline

Other

Anything else that maintainers should know about this PR:

@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (8999145) to head (3c5ac63).

Files with missing lines Patch % Lines
src/options.rs 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   62.57%   62.58%   +0.01%     
==========================================
  Files         130      130              
  Lines       18611    18619       +8     
==========================================
+ Hits        11645    11652       +7     
- Misses       6966     6967       +1     
Flag Coverage Δ
macos-14 50.24% <66.66%> (+0.02%) ⬆️
ubuntu-24.04 61.53% <66.66%> (+0.01%) ⬆️
windows-2022 49.98% <61.53%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClementTsang ClementTsang changed the title move cpu and memory settings over other: move cpu and memory settings over May 15, 2026
@ClementTsang ClementTsang force-pushed the config_migrations_p3 branch 2 times, most recently from 4c3a671 to 4fa9447 Compare May 15, 2026 22:41
@ClementTsang ClementTsang force-pushed the config_migrations_p3 branch from 4fa9447 to 23e478a Compare May 15, 2026 22:47
@ClementTsang ClementTsang marked this pull request as ready for review May 15, 2026 22:48
@ClementTsang ClementTsang merged commit 65acf5e into main May 16, 2026
39 checks passed
@ClementTsang ClementTsang deleted the config_migrations_p3 branch May 16, 2026 00:00
jamartin9 pushed a commit to jamartin9/bottom that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant