Skip to content

Conversation

@Max07B2
Copy link

@Max07B2 Max07B2 commented Oct 19, 2025

I updated the test matrix according to the following test scenario

Environment

  • HWv1
  • OSv2 (OpenMowerOS_20250916.img)
  • open_mower_ros: latest (I think sha-374264a)
  • Yard Force Classic 500 with mainboard 0_11_X_WT901
  • no NTRIP usage

Test scenario

  • Raspberry Pi Imager (v1.3.9) configuration
    • Hostname: <myhostname>
    • User: openmower
    • Pwd: <mypassword>
    • Wifi: <myssid>/<mywifipassword>
    • SSH: on with password
  • first startup
    • I don't know if it booted twice but I didn't need to manually reboot => look ok to me
    • ping <myhostname> ok (after maybe 1min)
    • ssh <myhostname> ok
    • lsb_release -a => ok
      No LSB modules are available.
      Distributor ID: Debian
      Description:    Debian GNU/Linux 13 (trixie)
      Release:        13
      Codename:       trixie
  • OpenMower Release cat /etc/rpi-issue => ok
  OpenMowerOS v2.x 2025-10-16
  Generated using pi-gen, https://github.com/RPi-Distro/pi-gen, 7dadcf1fc5ce1648ab09409ab978831690c9a955, stage-openmower
  • WebTerminal (ttyd)
    • http://<myhostname>:7681/
    • works, no password necessary
    • openmowercommand available
  • Dockge
    • http://<myhostname>:5001/
    • works, no password necessary
    • configure openmower environment for v1 hardware:
      • VERSION="latest" → leave unchanged
      • HARDWARE_PLATFORM=2HARDWARE_PLATFORM=1
      • MOWER="CHANGE_ME"MOWER="YardForce500"
      • FIRMWARE="CHANGE_ME"FIRMWARE="0_11_X_WT901"
      • save and start container
          [+] Running 38/38
           ✔ OpenMowerApp Pulled                12.0s 
           ✔ open_mower_ros Pulled             849.9s 
           ✔ Mosquitto Pulled                    7.7s 

          [+] Running 4/4
           ✔ Network openmower_default  Created  0.2s 
           ✔ Container OpenMowerApp     Started  6.8s 
           ✔ Container Mosquitto        Started  6.6s 
           ✔ Container open_mower_ros   Started  1.1s 
  • WebApp
  • configure parameters: openmower configure ros
    • left bind_ip: "172.16.78.1" unchanged, guess only applies for HWv2
    • changed datum_lat and datum_long to my coordinates
    • left NTRIP config unchanged, I don't use NTRIP and gps-rtk works for me, although it's not switched off explicitly (I will check the logs later)
    • changed the existing values in the yaml to my old values
    • after saving the file the container gets restarted automatically
  • map: I did not record a map, but copied my existing one from my OSv1 installation (scp map.bag openmower@<myhostname>:ros/ and scp checkpoint.bag openmower@<myhostname>:ros/)
  • restarted the container in dockge, tests with the mower worked

Comments on some points/results in the test matrix

  • Auto-reboot after initial boot: don't know if it rebooted, but it worked without manual action => ok for me
  • SSH enabled: as set in imager
  • Internal LAN: I guess that does not apply for HWv1 => --
  • ESC access: I did not check the correct motor, but I successfully connected each with VESC-Tool and the tool did the following mapping
    • right: ttyAMA3
    • mower: ttyAMA4
    • left: ttyAMA5
  • GNSS access: openmower expose-gps 921600 worked, but only if the container is stopped (I guess this is normal)

Summary by CodeRabbit

  • Documentation
    • Updated the hardware compatibility matrix reflecting test status changes across Raspberry Pi 4, Compute Module 4, and Compute Module 5 variants. Multiple features now show improved pass rates, including boot configuration, SSH enablement, Wi-Fi setup, and container access functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 19, 2025

Walkthrough

The TESTED_FEATURES.md test matrix was updated with new pass/fail statuses across Raspberry Pi hardware variants (Pi4, CM4, CM5). Multiple features transitioned from incomplete or failing states to passing, with some entries marked as non-applicable or experimental.

Changes

Cohort / File(s) Summary
Test Matrix Status Updates
TESTED_FEATURES.md
Updated hardware variant test statuses across numerous features (auto-reboot, Debian release, OpenMowerOS release, hostname configuration, SSH, Wi-Fi, LAN, and container access). Statuses changed from todo (🟡), warning (🟧), or failing (❌) to passing (✅), placeholder (--), or experimental (❌🧪) based on variant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Rationale: Documentation-only change with repetitive pattern updates (status cells across a matrix). While numerous cells were modified, changes follow consistent patterns and require verification rather than logic analysis.

Poem

🐰 The matrix now gleams with checkmarks so bright,
Pi4, CM4 dance in the testing light,
From yellow to green, the features take flight,
While CM5 still plots its upcoming plight,
A hop toward stability, bold and true!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Update TESTED_FEATURES.md with HWv1 test results" is specific, descriptive, and directly reflects the changeset. It clearly identifies the file being modified (TESTED_FEATURES.md) and the purpose of the changes (documenting HWv1 test results). The title aligns perfectly with the PR objectives, which state that the author updated the test matrix after running tests on HWv1 hardware. The phrasing is concise and avoids vague terminology, making it clear to teammates what was accomplished.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a723c5 and 478b7c7.

📒 Files selected for processing (1)
  • TESTED_FEATURES.md (1 hunks)
🔇 Additional comments (4)
TESTED_FEATURES.md (4)

7-7: Clarify auto-reboot status for Pi4.

The matrix marks Pi4 auto-reboot as ✅, but the PR description states "unsure about auto-reboot after initial boot." This is contradictory—either the test result is uncertain (🟡) or the PR objectives need clarification on what was actually observed.

Please confirm whether auto-reboot behavior was definitively tested and working on Pi4, or if this should remain marked as 🟡 pending explicit verification.


7-9: Verify CM4 and CM5 changes are in-scope for HWv1-only PR.

The PR objectives document HWv1 (Pi4) testing exclusively with a Yard Force Classic 500 and specific firmware. However, multiple CM4 cells show status updates across lines 7–26 (e.g., line 7 changes CM4 auto-reboot to ❌🧪, line 11 marks CM4 hostname non-default as ✅).

These CM4 and CM5 updates either belong to prior testing efforts or represent out-of-scope changes. Clarify whether:

  1. CM4/CM5 statuses were updated in a separate testing session and should be documented separately,
  2. Only Pi4 column should have been updated in this PR, or
  3. CM4/CM5 changes are from a different contributor.

Confirm the source and scope of all status changes across the three hardware columns.

Also applies to: 11-11, 13-13, 15-16, 21-26


19-19: Internal LAN correctly marked non-applicable.

The Pi4 "Internal LAN" status is marked as -- (non-applicable), which aligns with the PR description: "internal LAN marked not applicable for HWv1." This is appropriate.


21-26: Pi4 test results align well with PR observations.

The Pi4 updates for SSH, WebTerminal, Dockge, ESC access, GNSS access, and container shell (prefix) are all marked ✅ and are consistently supported by the PR description:

  • SSH and WebTerminal (ttyd) confirmed at :7681 ✅
  • Dockge confirmed at :5001 ✅
  • ESCs and GNSS exposure confirmed via openmower commands ✅
  • openmower configure ros and openmower command availability confirm container shell prefix ✅

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant