Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 1-hour rolling window approach to min-binning #192

Open
wants to merge 2 commits into
base: min-bins
Choose a base branch
from

Conversation

Nate-Wessel
Copy link
Contributor

@Nate-Wessel Nate-Wessel commented Feb 26, 2025

Working toward an approach where the binning window rolls along, discarding observations >= one hour older than its leading edge.

This would serve to prevent data from being aggregated together over long spans because of

  • discontinuities caused by the query parameters themselves
  • gaps just because the data is sparse

still need to define bins also by their ends
@Nate-Wessel
Copy link
Contributor Author

Still need to adjust the join of the bins back onto the data, as that's still a rolling join based on the bin ends.

@Nate-Wessel Nate-Wessel marked this pull request as ready for review February 27, 2025 16:35
@Nate-Wessel Nate-Wessel self-assigned this Feb 27, 2025
@Nate-Wessel
Copy link
Contributor Author

There's some inefficient code in here, but I'm pretty sure the logic per se is now sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant