Rethink how routing between nodes is done #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need yet to add some more guard rails around invalid selections so they don't throw a full-blown server error. E.g. report in a dignified way that a selected node doesn't exist. Also need to update the route docstring with the new param, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app strictly uses the Here network, but it's helpful for other purposes to generalize this and allow a compatible means of routing on the centreline network as well.
Eventually, the app may pull in data from other City sources, which is generally located on the centreline network.
This work also trims some long-deprecated fields from the link-nodes output.