Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: visualise instalments and alterations (hl-1496) #3547

Merged
merged 4 commits into from
Nov 19, 2024
Merged

feat: visualise instalments and alterations (hl-1496) #3547

merged 4 commits into from
Nov 19, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Nov 18, 2024 •
edited
Loading

Description ✨

Backend

  • Use alteration sum functions to get reduced amounts of benefits
  • Add amount_paid to store the amount reduced by alterations when talpa robot visits

Frontend

  • Visualise calculations with alterations in a single place
  • Reduce the amount from 2nd instalment if possible
    • If not, show how much recoveries have to be paid

2nd instalment

@sirtawast sirtawast requested a review from rikuke November 18, 2024 12:08
@sirtawast sirtawast changed the title feat: visualize instalments and alterations (hl-1496) feat: visualise instalments and alterations (hl-1496) Nov 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
11 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
58 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3547.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3547.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3547.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3547.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3547.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit f56e581 into main Nov 19, 2024
63 of 64 checks passed
@sirtawast sirtawast deleted the hl-1496 branch November 19, 2024 07:13
This was referenced Nov 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirtawast @terovirtanen @rikuke