Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preselect decision maker if it was selected before (hl-1530) #3522

Merged
merged 10 commits into from
Nov 11, 2024
Merged

fix: preselect decision maker if it was selected before (hl-1530) #3522

merged 10 commits into from
Nov 11, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Nov 7, 2024 •
edited
Loading

Description ✨

  • chore: Deprecate handler_role from backend
    • remove handler and handlerRole references from frontend
  • fix: decision maker validation
  • fix: pre-selection of decision maker radio button if it was previously selected
  • feat: add a new column to calculation review box that displays the selected decision maker
  • fix: store the appropriate decision maker to proposal by fetching it from backend using the id sent from frontend request rather than just writing the request values directly into db
  • chrore: remove redundant and unused file
  • fix: bug that caused application crash
    • ☠️ When writing a proposal and hit cancellation button in the action bar, then closing the modal

@sirtawast sirtawast requested a review from rikuke November 7, 2024 11:19
@sirtawast sirtawast changed the title Hl 1530 fix: preselect decision maker if was selected before (hl-1530) Nov 7, 2024
@sirtawast sirtawast changed the title fix: preselect decision maker if was selected before (hl-1530) fix: preselect decision maker if it was selected before (hl-1530) Nov 7, 2024
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3522.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3522.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3522.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3522.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3522.dev.hel.ninja 😿💢💥💥

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
11 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
56 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3522.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3522.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3522.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3522.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3522.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit 45095c5 into main Nov 11, 2024
64 checks passed
@sirtawast sirtawast deleted the hl-1530 branch November 11, 2024 07:45
This was referenced Nov 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirtawast @terovirtanen @rikuke