Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement instalments gui for handler (hl-1494) #3498

Merged
merged 5 commits into from
Nov 6, 2024
Merged

feat: implement instalments gui for handler (hl-1494) #3498

merged 5 commits into from
Nov 6, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Nov 1, 2024 •
edited
Loading

Description ✨

  • Create API endpoint for PATCHing status for Instalment
  • List pending_instalment in application's simplified_list API call
  • Add new tab for instalments
  • Add new table to list applications to select instalment and choose an action

@sirtawast sirtawast force-pushed the hl-1527 branch 3 times, most recently from 074879c to 8b8cdfc Compare November 1, 2024 13:22
@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3498.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3498.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3498.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3498.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3498.dev.hel.ninja 😆🎉🎉🎉

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
11 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
57 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarCloud

@sirtawast sirtawast changed the title feat: implement instalments gui for handler (hl-1527) feat: implement instalments gui for handler (hl-1494) Nov 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3498.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3498.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3498.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3498.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3498.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast requested a review from rikuke November 6, 2024 12:30
@sirtawast sirtawast mentioned this pull request Nov 6, 2024
Merged
@sirtawast sirtawast merged commit aaff375 into main Nov 6, 2024
65 checks passed
@sirtawast sirtawast deleted the hl-1527 branch November 6, 2024 13:09
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Merged
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirtawast @terovirtanen