Add accessType to search pages #1555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonatank
requested changes
Feb 12, 2025
| /> | ||
| ), | ||
| value: t( | ||
| `reservationUnit:accessTypes.${reservationUnit.currentAccessType}` |
There was a problem hiding this comment.
Shouldn't be possible to my knowledge, as all reservation units have an accessType (which currentAccessType defaults to, if it's not specified separately)
| /> | ||
| ), | ||
| value: t( | ||
| `reservationUnit:accessTypes.${reservationUnit.currentAccessType}` |
There was a problem hiding this comment.
Same as above: shouldn't be possible to my knowledge, as all reservation units have an accessType (which currentAccessType defaults to, if it's not specified separately)
There was a problem hiding this comment.
this changes in the new backend
- remove unnecessary helper functions from modules/search - replace remaining instances of removed query param helper functions with toNumber and/or ignoreMaybeArray
vincit-matu
force-pushed
the
add-accessType-to-search-pages
branch
from
9ec3ff7 to
6b6ad63
Compare
|
joonatank
approved these changes
Feb 13, 2025
joonatank
requested changes
Feb 17, 2025
| /> | ||
| ), | ||
| value: t( | ||
| `reservationUnit:accessTypes.${reservationUnit.currentAccessType}` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
accessTypeto both search pages. Both to the form/filters, and the search result reservation cards🧪 Test plan
accessType, and that it works (most/all reservation units use the "Suora pääsy" option for now)🚧 Dependencies
🎫 Tickets