Refactor application flow #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonatank
force-pushed
the
refactor-application-flow
branch
from
85df3ce to
ec90085
Compare
matti-lamppu
force-pushed
the
the-convergence
branch
from
9965355 to
9e1ddfe
Compare
joonatank
force-pushed
the
refactor-application-flow
branch
6 times, most recently
from
ab6dce5 to
8e4e95f
Compare
joonatank
force-pushed
the
refactor-application-flow
branch
from
8e4e95f to
4be1195
Compare
joonatank
force-pushed
the
add-adult-checks
branch
from
e21396b to
47820bf
Compare
joonatank
force-pushed
the
refactor-application-flow
branch
from
7ad745f to
ccae0b5
Compare
joonatank
force-pushed
the
refactor-application-flow
branch
from
6e8befb to
0711389
Compare
joonatank
commented
Feb 17, 2025
vincit-matu
approved these changes
Feb 17, 2025
joonatank
force-pushed
the
refactor-application-flow
branch
from
0711389 to
a65652d
Compare
- Use form state instead of separate useStates. - Fix: invalid query filter
The schema is cleaner if we register / unregister the necessary fields. This allows us to use a single top level undefined for a field that should not be validate instead of writing custom validation logic.
add: cleaner Error component for custom form errors
- Make some inputs read-only - Don't allow updating user or application round - Move working memo update to own endpoint - Validate number of application sections
- use schemas to validate all pages before sending and display an error with a link to the page. - use schemas to validate the exact step (funnel page) user has access - fix: individual address broken to form conversion
joonatank
force-pushed
the
refactor-application-flow
branch
from
a65652d to
97fcce7
Compare
|
|
#1550 merged into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
customer🚧 Dependencies
🎫 Tickets