Allow empty working memo in reservation memo update

City-of-Helsinki · Feb 13, 2025 · 61a124c · 61a124c
1 parent 030fc70
commit 61a124c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/backend/tests/test_graphql_api/test_reservation/test_working_memo_update.py b/backend/tests/test_graphql_api/test_reservation/test_working_memo_update.py
@@ -107,3 +107,17 @@ def test_reservation__update__working_memo__reserver_staff_user_and_not_own_rese
 
     reservation.refresh_from_db()
     assert reservation.working_memo == ""
+
+
+def test_reservation__update__empty(graphql):
+    reservation = ReservationFactory.create(working_memo="foo")
+    graphql.login_with_superuser()
+
+    data = {"pk": reservation.pk, "workingMemo": ""}
+
+    response = graphql(UPDATE_WORKING_MEMO_MUTATION, input_data=data)
+
+    assert response.has_errors is False, response.errors
+
+    reservation.refresh_from_db()
+    assert reservation.working_memo == ""
diff --git a/backend/tilavarauspalvelu/api/graphql/types/reservation/serializers/memo_serializers.py b/backend/tilavarauspalvelu/api/graphql/types/reservation/serializers/memo_serializers.py
@@ -10,7 +10,7 @@ class ReservationWorkingMemoSerializer(NestingModelSerializer):
     """Update the working memo of a reservation."""
 
     pk = IntegerField(required=True)
-    working_memo = CharField(required=True, allow_blank=False)
+    working_memo = CharField(required=True, allow_blank=True)
 
     class Meta:
         model = Reservation