Migrate to React v18 (vol 2) #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
japauliina
commented
Nov 26, 2024
japauliina
commented
- Re-apply changes of #1192
- Temporary remove HDS and comment out code that uses it
- Use legacy-peer-deps flag in install
This will remedy deprecated React component lifecycle warnings.
ReadFeedbackLink requires fi/sv/en unit names, thus introduce defaults for them.
This fixes warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>
This fixes warning: validateDOMNesting(...): <div> cannot appear as a descendant of <div>
defaultProps is a legacy way of setting default values to props in React components. It is recommended to use default parameters in function components instead.
ListItem button-attribute has been removed in Material UI v6. Use ListItemButton instead.
This is a breaking change between react-leaflet v3 and v4: https://github.com/PaulLeCam/react-leaflet/blob/master/CHANGELOG.md#v400-2022-04-18. Fixed by using `ref` callback instead of `whenCreated`.
Also update Leaflet interactive focus outline to none as it generates undesired blue outlines for geometry extends to the map.
Updates: - Prefer configuration file over command line arguments - Move SMCookies under new feature-flag - Update tests to automatically accept cookie consents when needed
Temporary remove HDS and comment out code that uses it to fix the React v18 upgrade issues.
Use legacy-peer-deps flag in install to bypass the peer dependency conflicts.
japauliina
force-pushed
the
react-18-upgrade-vol-2
branch
from
b1df904 to
fd49667
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.