-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Dart Sass @import/global built-in function deprecation warnings
remove Dart Sass 3.0.0 deprecation warnings when building: - Sass @import rules are deprecated - Global built-in functions are deprecated done: - `@import` → `@use` + namespacing functions and variables, e.g. `$breakpoint-m` → `hds.$breakpoint-m` - exporting variables from .scss file to another by `@forward`, e.g. all `hds-design-tokens`'s variables are now explicitly exported from `variables.scss` - `map-has-key` → `@use "sass:map"` + `map.has-key` - `map-get` → `@use "sass:map"` + `map.get` - changed some constants from CSS style to SASS style: - var(--breakpoint-xl) → variables.$breakpoint-xl - var(--color-black) → variables.$color-black - var(--color-black-5) → variables.$color-black-5 - var(--color-summer) → variables.$color-summer - var(--color-white) → variables.$color-white - var(--spacing-2-xs) → variables.$spacing-2-xs - var(--spacing-l) → variables.$spacing-l - var(--spacing-layout-m) → variables.$spacing-layout-m - var(--spacing-layout-s) → variables.$spacing-layout-s - var(--spacing-layout-s) → variables.$spacing-layout-s - var(--spacing-layout-xs) → variables.$spacing-layout-xs - var(--spacing-m) → variables.$spacing-m - var(--spacing-s) → variables.$spacing-s - var(--spacing-s) → variables.$spacing-s - Specifically in listPageLayout.module.scss: - removed unnecessary calc() use from `$backButtonAsideBreakpoint`: - `calc($backButtonWidth + $breakpoint-xl);` → `$backButtonWidth + variables.$breakpoint-xl;` - removed unnecessary SASS → CSS variable mapping by removing `--back-button-width: #{$backButtonWidth};` - simplified calculation `margin-left: calc(#{var(--back-button-width)} * -1);` → `margin-left: $backButtonWidth * -1;` - **NOTE**: Replaced `var(--color-text)` with `variables.$color-black-90` as there was no variable `color-text` i.e. **it had no value at all** - Specifically in hero.module.scss: - Changed from using min-height calculation using CSS and interpolation to using SASS calculations directly i.e. `min-height: calc(0.265 * #{$containerMaxWidth});` → `min-height: 0.265 * variables.$containerMaxWidth;` refs KK-1372
- Loading branch information
1 parent
1aa1b77
commit bef6e02
Showing
57 changed files
with
512 additions
and
512 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
@import '~styles/variables'; | ||
@use '~styles/variables'; | ||
|
||
.modal { | ||
text-align: center; | ||
} | ||
|
||
.okButton { | ||
margin: $largeMargin 0; | ||
margin: variables.$largeMargin 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
@import '~styles/variables'; | ||
@use '~styles/variables'; | ||
|
||
.button { | ||
--color: var(--color-black); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,24 @@ | ||
@import '~styles/variables'; | ||
@import '~styles/layout'; | ||
@use '~styles/variables'; | ||
@use '~styles/layout'; | ||
|
||
.modal { | ||
text-align: center; | ||
} | ||
|
||
.buttonGroup { | ||
margin: $largeMargin 0; | ||
margin: variables.$largeMargin 0; | ||
|
||
@include respond-above(m) { | ||
@include layout.respond-above(m) { | ||
display: grid; | ||
grid-gap: $baseMargin; | ||
grid-gap: variables.$baseMargin; | ||
grid-auto-flow: column; | ||
} | ||
|
||
@include respond-below(m) { | ||
@include layout.respond-below(m) { | ||
display: flex; | ||
flex-direction: column-reverse; | ||
.okButton { | ||
margin-bottom: $baseMargin; | ||
margin-bottom: variables.$baseMargin; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
@import '~styles/layout'; | ||
@import '~styles/variables'; | ||
@use '~styles/layout'; | ||
@use '~styles/variables'; | ||
|
||
.error { | ||
margin: $baseMargin; | ||
@include respond-above(m) { | ||
margin: variables.$baseMargin; | ||
@include layout.respond-above(m) { | ||
grid-column: 2; | ||
margin: $baseMargin 0; | ||
margin: variables.$baseMargin 0; | ||
} | ||
} |
4 changes: 2 additions & 2 deletions
4
src/common/components/formikWrappers/formikInputs.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/common/components/giveFeedbackButton/giveFeedbackButton.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.