Addition of service graph modules and their test files (DCNE-410) #754

shrsr · 2025-05-06T19:09:22Z

This PR contains completed service graph modules from #186

plugins/module_utils/aci.py

plugins/modules/aci_l4l7_device_selection_policy.py

plugins/modules/aci_l4l7_service_graph_template.py

plugins/modules/aci_l4l7_service_graph_template_abs_connection.py

plugins/modules/aci_l4l7_service_graph_template_node.py

plugins/modules/aci_l4l7_service_graph_template_term_node.py

samiib · 2025-05-09T10:36:03Z

plugins/modules/aci_l4l7_device_selection_interface_context.py

+- cisco.aci.annotation
+
+notes:
+- The I(tenant), I(graph), I(contract) and I(node) must exist before using this module in your playbook.


Suggested change

- The I(tenant), I(graph), I(contract) and I(node) must exist before using this module in your playbook.

- The O(tenant), O(graph), O(contract) and O(node) must exist before using this module in your playbook.

This comment was already made by @gmicol in a related PR. In ansible ACI collection we've been using I() for Input in the other modules. I believe that this usage should be consistent within this collection.

samiib · 2025-05-09T10:37:00Z

plugins/modules/aci_l4l7_device_selection_interface_context.py

+    type: str
+  permit_handoff:
+    description:
+    - Indicates whether to allow handoff of traffic to the associated logical interface.


Does APIC default these Booleans to anything when unset? permit_handoff, acl, rule_type?

samiib · 2025-05-09T10:39:18Z

plugins/modules/aci_l4l7_device_selection_interface_context.py

+                    # child_configs.append(
+                    #     {
+                    #         "vnsRsLIfCtxToBD": {
+                    #             "attributes": {
+                    #                 "dn": child.get("vnsRsLIfCtxToBD").get("attributes").get("dn"),
+                    #                 "status": "deleted",
+                    #             }
+                    #         }
+                    #     }
+                    # )


Suggested change

# child_configs.append(

# {

# "vnsRsLIfCtxToBD": {

# "attributes": {

# "dn": child.get("vnsRsLIfCtxToBD").get("attributes").get("dn"),

# "status": "deleted",

# }

# }

# }

# )

Not sure if you need the previous code. I think the comment is fine.

We left the code commented in other modules as well. I left it to be consistent with them..

@shrsr why are we keeping this commented code? When should we uncomment it? Is there something blocking?

Example -> In aci_access_span_src_group_src and a few modules we have the code commented to show that the traditional way of deleting the child is not possible with a code snippet. I can still remove it if it is not relevant..

if child.get("spanRsSrcToFilterGrp") and child.get("spanRsSrcToFilterGrp").get("attributes").get("tDn") != filter_group_tdn: # Appending to child_config list not possible because of APIC Error 103: child (Rn) of class spanRsSrcGrpToFilterGrp is already attached. # A seperate delete request to dn of the spanRsSrcGrpToFilterGrp is needed to remove the object prior to adding to child_configs. # Failed child_config is displayed in below: # # child_configs.append( # { # "spanRsSrcGrpToFilterGrp": { # "attributes": { # "dn": "uni/infra/srcgrp-{0}/src-{1}/rssrcGrpToFilterGrp".format(source_group, source), # "status": "deleted", # } # } # } # )

samiib · 2025-05-09T10:40:12Z

plugins/modules/aci_l4l7_device_selection_policy.py

+- cisco.aci.aci
+- cisco.aci.annotation
+notes:
+- The I(tenant), I(contract), I(graph), I(device) and I(node) must exist before using this module in your playbook.


Suggested change

- The I(tenant), I(contract), I(graph), I(device) and I(node) must exist before using this module in your playbook.

- The O(tenant), O(contract), O(graph), O(device) and O(node) must exist before using this module in your playbook.

Same comment as above

samiib · 2025-05-09T10:42:14Z

plugins/modules/aci_l4l7_service_graph_template.py

+- cisco.aci.annotation
+- cisco.aci.owner
+notes:
+- The I(tenant) must exist before using this module in your playbook.


Suggested change

- The I(tenant) must exist before using this module in your playbook.

- The O(tenant) must exist before using this module in your playbook.

Same comment as above

plugins/modules/aci_l4l7_service_graph_template_node.py

samiib · 2025-05-09T10:52:22Z

plugins/modules/aci_l4l7_service_graph_template_node.py

+    choices: [ redirect, unspecified ]
+  is_copy:
+    description:
+    - Whether the device is a copy device.


samiib · 2025-05-09T10:52:31Z

plugins/modules/aci_l4l7_service_graph_template_node.py

+    type: bool
+  share_encap:
+    description:
+    - Whether to share encapsulation across the service graph.


samiib · 2025-05-09T10:52:45Z

plugins/modules/aci_l4l7_service_graph_template_node.py

+- cisco.aci.annotation
+- cisco.aci.owner
+notes:
+- The I(tenant), I(service_graph) and I(device) must exist before using this module in your playbook.


Suggested change

- The I(tenant), I(service_graph) and I(device) must exist before using this module in your playbook.

- The O(tenant), O(service_graph) and O(device) must exist before using this module in your playbook.

Same comment as above

samiib · 2025-05-09T10:53:28Z

plugins/modules/aci_l4l7_service_graph_template_term_node.py

+- cisco.aci.annotation
+- cisco.aci.owner
+notes:
+- The I(tenant) and I(service_graph) must exist before using this module in your playbook.


Suggested change

- The I(tenant) and I(service_graph) must exist before using this module in your playbook.

- The O(tenant) and O(service_graph) must exist before using this module in your playbook.

Same comment as above

akinross

LGTM

samiib

LGTM

gmicol

LGTM

anvitha-jain · 2025-05-13T18:16:43Z

plugins/modules/aci_l4l7_service_graph_template_abs_connection.py

+    type: bool
+  adjacency_type:
+    description:
+    - Whether the adjacecncy is Layer2 or Layer3.


adjacecncy -> adjacency

anvitha-jain · 2025-05-13T18:17:04Z

plugins/modules/aci_l4l7_service_graph_template_abs_connection.py

+  connector_direction:
+    description:
+    - The connector direction.
+    - The APIC defaults to C(uknown) when unset during creation.


uknown -> unknown

samiib

LGTM

akinross

LGTM

anvitha-jain

LGTM

akinross

LGTM

gmicol

LGTM

…h_template_node module

…tion_interface_context module

…ervice_graph_template modules

…mplate modules

…te_abs_connection

samiib

LGTM

shrsr self-assigned this May 6, 2025

shrsr requested review from akinross, anvitha-jain, gmicol, lhercot, sajagana and samiib as code owners May 6, 2025 19:09

shrsr added the jira-sync Sync this issue to Jira label May 6, 2025

github-actions bot changed the title ~~Addition of service graph modules and their test files~~ Addition of service graph modules and their test files (DCNE-410) May 6, 2025

akinross requested changes May 7, 2025

View reviewed changes

shrsr requested a review from akinross May 8, 2025 20:36

samiib requested changes May 9, 2025

View reviewed changes

shrsr requested a review from samiib May 11, 2025 23:44

akinross previously approved these changes May 12, 2025

View reviewed changes

samiib previously approved these changes May 12, 2025

View reviewed changes

gmicol previously approved these changes May 13, 2025

View reviewed changes

anvitha-jain requested changes May 13, 2025

View reviewed changes

shrsr dismissed stale reviews from gmicol, samiib, and akinross via d106403 May 13, 2025 19:49

shrsr requested review from anvitha-jain, akinross, samiib and gmicol May 13, 2025 19:49

samiib previously approved these changes May 14, 2025

View reviewed changes

akinross reviewed May 15, 2025

View reviewed changes

anvitha-jain previously approved these changes May 15, 2025

View reviewed changes

akinross self-requested a review May 16, 2025 08:37

akinross previously approved these changes May 16, 2025

View reviewed changes

gmicol previously approved these changes May 22, 2025

View reviewed changes

shrsr added 7 commits May 23, 2025 12:26

[minor_change] Addition of service graph modules and their test files

c3b147a

[ignore] Modified files to adhere to black formatting in service_grap…

c8b7e31

…h_template_node module

[ignore] Modified files to adhere to black formatting in device_selec…

358484f

…tion_interface_context module

[ignore] Added new attributes to service_graph_template modules

bd30ac9

[ignore] Added namespace and collection to see also note in docs of s…

eb76e2e

…ervice_graph_template modules

[ignore] Added default values in the description for service_graph_te…

bb23486

…mplate modules

[ignore] Changes description of docs in aci_l4l7_service_graph_templa…

1f791c9

…te_abs_connection

shrsr dismissed stale reviews from gmicol, akinross, anvitha-jain, and samiib via 1f791c9 May 23, 2025 16:27

shrsr force-pushed the graph branch from d106403 to 1f791c9 Compare May 23, 2025 16:27

samiib approved these changes May 24, 2025

View reviewed changes

	- The I(tenant), I(graph), I(contract) and I(node) must exist before using this module in your playbook.
	- The O(tenant), O(graph), O(contract) and O(node) must exist before using this module in your playbook.

	- The I(tenant), I(contract), I(graph), I(device) and I(node) must exist before using this module in your playbook.
	- The O(tenant), O(contract), O(graph), O(device) and O(node) must exist before using this module in your playbook.

	- The I(tenant) must exist before using this module in your playbook.
	- The O(tenant) must exist before using this module in your playbook.

	- The I(tenant), I(service_graph) and I(device) must exist before using this module in your playbook.
	- The O(tenant), O(service_graph) and O(device) must exist before using this module in your playbook.

	- The I(tenant) and I(service_graph) must exist before using this module in your playbook.
	- The O(tenant) and O(service_graph) must exist before using this module in your playbook.

Addition of service graph modules and their test files (DCNE-410) #754

Are you sure you want to change the base?

Addition of service graph modules and their test files (DCNE-410) #754

Uh oh!

Conversation

shrsr commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shrsr May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

gmicol left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

anvitha-jain left a comment

Choose a reason for hiding this comment

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

shrsr commented May 6, 2025 •

edited

Loading

shrsr May 11, 2025 •

edited

Loading