-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 适配新增的 "server_version" 和 "server_type" 字段 #40
base: main
Are you sure you want to change the base?
Conversation
消息对象的更新类图classDiagram
class Message {
server_name: string
server_version: string
server_type: string
event_name: string
post_type: string
player: string
message: string
sub_type: string
}
note for Message "Added server_version, server_type and event_name fields"
文件级别更改
提示和命令与 Sourcery 交互
自定义您的体验访问您的 仪表板 以:
获得帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request adapts the Sequence diagram for processing a messagesequenceDiagram
participant Config
participant SendMsg
participant getMessage
Config->>SendMsg: getConfig()
SendMsg->>getMessage: getMessage(jsonMsg, mc_qq_display_server_name)
activate getMessage
getMessage-->>SendMsg: msg
deactivate getMessage
SendMsg->>SendMsg: serverConfig = mc_qq_server_list.find(...)
SendMsg->>SendMsg: msg = msg.replace(...)
Updated class diagram for the message objectclassDiagram
class Message {
server_name: string
server_version: string
server_type: string
event_name: string
post_type: string
player: string
message: string
sub_type: string
}
note for Message "Added server_version, server_type and event_name fields"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @17TheWord - 我已经查看了你的更改 - 这里有一些反馈:
总体评论:
- 考虑将
Config.getConfig()
解构为单独的变量,以提高可读性。
以下是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请点击每个评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @17TheWord - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider destructuring
Config.getConfig()
into individual variables to improve readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sourcery 总结
增强:
getMessage
函数,使其能够处理消息对象中新增的server_version
、server_type
和event_name
字段Original summary in English
Summary by Sourcery
Enhancements:
getMessage
function to handle the newserver_version
,server_type
, andevent_name
fields in the message object