fix: Wait until daemon is started#2327
Merged
Merged
Conversation
OrKoN
approved these changes
Jul 9, 2026
Collaborator
|
Thanks! |
Collaborator
Author
|
Thanks for the review! |
Merged
via the queue into
ChromeDevTools:main
with commit Jul 9, 2026
ed7e95d
28 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startDeamon was only waiting until until daemon.pid existed. But it is possible that daemon.pid was created but the daemon wasn't ready yet. This was observable through flaky test runner failures. Therefore startDaemon now also waits until the daemon successfully replies to an initial status message.