Skip to content

feat: restart active performance traces#2326

Closed
godququ5-code wants to merge 1 commit into
ChromeDevTools:mainfrom
godququ5-code:fix-808-restart-performance-trace
Closed

feat: restart active performance traces#2326
godququ5-code wants to merge 1 commit into
ChromeDevTools:mainfrom
godququ5-code:fix-808-restart-performance-trace

Conversation

@godququ5-code

Copy link
Copy Markdown

Summary

  • stop any currently running performance trace before starting a new one
  • add a short notice when an existing trace is replaced
  • cover the restart path with a regression test

Fixes #808.

Validation

  • npm run test tests/tools/performance.test.ts
  • npm run build
  • npm run check-format

@google-cla

google-cla Bot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@godququ5-code godququ5-code force-pushed the fix-808-restart-performance-trace branch from a6a7bf6 to c0524d2 Compare July 8, 2026 17:20
@godququ5-code godququ5-code marked this pull request as ready for review July 8, 2026 17:27
@godququ5-code godququ5-code force-pushed the fix-808-restart-performance-trace branch from c0524d2 to d4848df Compare July 8, 2026 17:30
@OrKoN

OrKoN commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR but we are still collecting feedback on the linked issue.

@OrKoN OrKoN closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop running trace when starting a new trace

2 participants