feat: add screencast fps option#2312
Open
mturac wants to merge 1 commit into
Open
Conversation
c4943e1 to
f07fbee
Compare
Author
|
Validation refreshed on the current head: git diff --check origin/main...HEAD
npm run test -- tests/tools/screencast.test.ts tests/cli.test.ts
npm run check-formatAll three passed locally. |
f07fbee to
ff8a821
Compare
Author
|
Rebased this branch onto the current Validation:
|
588e69d to
f126440
Compare
f126440 to
7aec640
Compare
Contributor
|
Thanks for your pr! Since the direction for the linked issue #2291 hasn't been fully confirmed yet, let's hold off on merging or closing it for now. We can keep this on hold until we get definitive confirmation on the final direction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2291.
Summary
--experimental-screencast-fpsoption for screencast recording--experimental-screencastscreencast()callTesting
git diff --check origin/main...HEADnpm run check-formatnpm run typechecknpm test -- --test-only tests/tools/screencast.test.ts tests/cli.test.ts