Skip to content

feat: add screencast fps option#2312

Open
mturac wants to merge 1 commit into
ChromeDevTools:mainfrom
mturac:izon/screencast-fps
Open

feat: add screencast fps option#2312
mturac wants to merge 1 commit into
ChromeDevTools:mainfrom
mturac:izon/screencast-fps

Conversation

@mturac

@mturac mturac commented Jul 7, 2026

Copy link
Copy Markdown

Addresses #2291.

Summary

  • add an --experimental-screencast-fps option for screencast recording
  • validate the value as a positive integer and imply --experimental-screencast
  • pass the configured FPS through to Puppeteer's screencast() call
  • update generated option docs and flag telemetry metadata

Testing

  • git diff --check origin/main...HEAD
  • npm run check-format
  • npm run typecheck
  • npm test -- --test-only tests/tools/screencast.test.ts tests/cli.test.ts

@mturac mturac force-pushed the izon/screencast-fps branch 6 times, most recently from c4943e1 to f07fbee Compare July 8, 2026 19:47
@mturac

mturac commented Jul 9, 2026

Copy link
Copy Markdown
Author

Validation refreshed on the current head:

git diff --check origin/main...HEAD
npm run test -- tests/tools/screencast.test.ts tests/cli.test.ts
npm run check-format

All three passed locally.

@mturac mturac force-pushed the izon/screencast-fps branch from f07fbee to ff8a821 Compare July 9, 2026 07:28
@mturac

mturac commented Jul 9, 2026

Copy link
Copy Markdown
Author

Rebased this branch onto the current main and re-ran validation.

Validation:

  • git diff --check origin/main...HEAD
  • npm run test -- tests/tools/screencast.test.ts tests/cli.test.ts
  • npm run check-format

@mturac mturac force-pushed the izon/screencast-fps branch 6 times, most recently from 588e69d to f126440 Compare July 9, 2026 11:58
@mturac mturac force-pushed the izon/screencast-fps branch from f126440 to 7aec640 Compare July 9, 2026 14:38
@nattallius

Copy link
Copy Markdown
Contributor

Thanks for your pr! Since the direction for the linked issue #2291 hasn't been fully confirmed yet, let's hold off on merging or closing it for now. We can keep this on hold until we get definitive confirmation on the final direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants