Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/bin/chrome-devtools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,18 @@ async function start(args: string[], sessionId: string) {

const defaultArgs = ['--viaCli', '--experimentalStructuredContent'];

function getDefaultedStartArgs(
argv: Record<string, unknown>,
): string[] {
if (argv.isolated === undefined && argv.userDataDir === undefined) {
argv.isolated = true;
}
if (argv.headless === undefined) {
argv.headless = true;
}
return serializeArgs(cliOptions, argv);
}

const startCliOptions = {
...cliOptions,
} as Partial<typeof cliOptions>;
Expand Down Expand Up @@ -96,13 +108,7 @@ y.command(
await stopDaemon(argv.sessionId);
}
// Defaults but we do not want to affect the yargs conflict resolution.
if (argv.isolated === undefined && argv.userDataDir === undefined) {
argv.isolated = true;
}
if (argv.headless === undefined) {
argv.headless = true;
}
const args = serializeArgs(cliOptions, argv);
const args = getDefaultedStartArgs(argv);
await start(args, argv.sessionId);
process.exit(0);
},
Expand Down Expand Up @@ -226,7 +232,8 @@ for (const [commandName, commandDef] of Object.entries(commands)) {
const sessionId = argv.sessionId as string;
try {
if (!isDaemonRunning(sessionId)) {
await start([], sessionId);
const args = getDefaultedStartArgs({});
await start(args, sessionId);
}

const commandArgs: Record<string, unknown> = {};
Expand Down
Loading