Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MICROWIN] Optimize ISO Access with Cached Read #3000

Closed
wants to merge 6 commits into from
Closed

[MICROWIN] Optimize ISO Access with Cached Read #3000

wants to merge 6 commits into from

Conversation

MyDrift-user
Copy link
Contributor

@MyDrift-user MyDrift-user commented Nov 1, 2024 •
edited
Loading

awaiting for #2888 to get merged

Type of Change

  • Refactoring

Description

read image once, then take info from the result of that.

TODO:

  • exit loop if pro found
  • remove need to look through all editions individually using Get-WindowsImage

Impact

  • faster process of getting ISO

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@MyDrift-user
[FEAT] change/add some icons
affedd3 
- change settings & close icon to new one using "Segoe Fluent Icons" fontfamily
- add icons to search context menu using "Segoe Fluent Icons" fontfamily
@CodingWonders

This comment was marked as outdated.

Sign in to view
@MyDrift-user
refractor PR
125e78b 
- remove "Segoe Fluent Icons" changes
- add Invoke-WPFGetIso improvements from ChrisTitusTech#2731
> read image once, then take info from the result of that.
@MyDrift-user MyDrift-user changed the title [FEAT] Update Icons [MICROWIN] Optimize ISO Access with Cached Read Nov 1, 2024
@MyDrift-user MyDrift-user marked this pull request as ready for review November 5, 2024 22:09
@CodingWonders

This comment was marked as outdated.

Sign in to view
@CodingWonders

This comment was marked as outdated.

Sign in to view
@MyDrift-user MyDrift-user marked this pull request as draft November 6, 2024 08:00
@MyDrift-user
restore usage of EditionID
f3bffa9 
TODO: fetch EditionID foreach index without looping Get-WindowsImage
MyDrift-user and others added 3 commits November 6, 2024 17:44
@MyDrift-user @CodingWonders
write info into shell for user
b5c80bf 
Co-authored-by: CodingWonders <[email protected]>
@MyDrift-user
fix tabs
8ac72dc 
- correctly layout changes suggested via github
@MyDrift-user
move console log & index setting
4ae82c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodingWonders CodingWonders CodingWonders approved these changes

@ChrisTitusTech ChrisTitusTech Awaiting requested review from ChrisTitusTech ChrisTitusTech is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MyDrift-user @CodingWonders