Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MicroWin] Remove test-path for issue fix #2585

Merged

Conversation

CodingWonders
Copy link
Contributor

@CodingWonders CodingWonders commented Aug 19, 2024

Pull Request

Title

(Same as title)

Type of Change

  • Bug fix

Description

This PR removes the Test-Path condition, which is the culprit for ISOs being double their initial size by including both the unmodified and modified install.wim files.

For example, when I implemented registry cmdlets for DISMTools, it took an insanely huge amount of attempts to unlock the registry, so I replaced them with REG commands.

Link to DT commit

In short: Using registry cmdlets for offline images holds "System" process file locks for an uncertain amount of time until they are released, at which point unmounting has failed. Forcing a manual release of the lock will crash the system.

One reason to rant about PowerShell, I guess.

Testing

It should finish successfully

Impact

ISO files not being ludicrously huge

Issue related to PR

  • Aug. 19 Stream

Additional Information

No documentation changes were required

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@CodingWonders
Copy link
Contributor Author

This was the issue altogether

@MyDrift-user
Copy link
Contributor

MyDrift-user commented Aug 19, 2024

@CodingWonders @ChrisTitusTech
Tested out this PR, it resolved all Issues I noticed and was able to see in the shell after the latest Release, In addition the Filesize is back to ~5.85 GB calculeted correctly from byte to GB.

@CodingWonders CodingWonders marked this pull request as ready for review August 19, 2024 22:51
@ChrisTitusTech ChrisTitusTech merged commit bcfbce6 into ChrisTitusTech:main Aug 22, 2024
1 check passed
mews-se added a commit to mews-se/winutil that referenced this pull request Aug 22, 2024
@CodingWonders CodingWonders deleted the microwin-fix-240820 branch August 24, 2024 13:55
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants