Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Apply PR #2472 but for 'CONTRIBUTING.md' File #2538

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Aug 8, 2024

Type of Change

  • Documentation update
  • Hotfix

Description

Due to short sighting on my end, I haven't notified @MyDrift-user in his PR #2481 that docs/contribute.md file has been updated in PR #2472, meaning the Out Dated version of docs/contribute.md file was copy-pasted into CONTRIBUTING.md file, which "reverted" changes made in PR #2472.

Testing

Built & Deployed these changes from my Fork (specifically this PR Branch), and it works without a problem.

Link to docs preview: https://og-mrk.github.io/winutil/contribute/

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Note

The build & deploy of github pages generates several warnings, I'll make a PR soon addressing this, but the changes introduced in this PR does not produce any extra errors or errors related to the changes.

@og-mrk og-mrk requested a review from ChrisTitusTech as a code owner August 8, 2024 06:18
Copy link
Contributor

@MyDrift-user MyDrift-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I should have pulled the changes first ...

@ChrisTitusTech ChrisTitusTech merged commit 5acbfbd into ChrisTitusTech:main Aug 9, 2024
1 check passed
@og-mrk og-mrk deleted the reapply-pr2472 branch August 20, 2024 13:44
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants