Skip to content

fix(agent): stop thinking timer on abort by emitting abort stream part #13568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeJeune wants to merge 3 commits into
base: main
Choose a base branch
from
+45 −1
Open

fix(agent): stop thinking timer on abort by emitting abort stream part #13568

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe07f55
fix(agent): stop thinking timer on abort by emitting abort stream part
DeJeune Mar 17, 2026
1e12f47
fix(agent): stop thinking timer on abort via stream lifecycle middleware
DeJeune Mar 18, 2026
63c7612
fix(agent): propagate non-abort errors in stream lifecycle middleware
DeJeune Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/renderer/src/store/thunk/messageThunk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,14 @@ const createSSEReadableStream = (

const abortHandler = () => {
cancelReader(signal.reason ?? 'aborted')
// Enqueue an 'abort' stream part before erroring, matching AI SDK stream behavior.
// Without this, AiSdkToChunkAdapter never emits the ERROR chunk, so callbacks.onError
// is never called and block statuses (e.g., thinking timer) are not updated on abort.
try {
controller.enqueue({ type: 'abort' } as TextStreamPart<Record<string, any>>)
} catch {
// Controller may already be closed
}
controller.error(new DOMException('Aborted', 'AbortError'))
}

Expand Down
Loading