fix: Format provider API hosts in API server & refactor shared utilities

[EurFelux]

What this PR does

Before this PR:

The API server used raw provider apiHost values from Redux without formatting. This meant provider-specific URL transformations (e.g., appending /v1, Ollama /api suffix, Azure /openai suffix) were skipped, causing upstream API calls to hit incorrect URLs (often resulting in 404 errors). Additionally, shared utility functions (API host formatting, provider type checks, Claude provider constants) were tightly coupled to the renderer process and unavailable to the main process.

After this PR:

• API utility functions (formatApiHost, withoutTrailingSlash, hasAPIVersion, etc.) are moved to packages/shared/utils/api/
• Provider type check functions (isAnthropicProvider, isOllamaProvider, etc.) are moved to packages/shared/aiCore/provider/utils/
• Provider-specific API host formatters (formatOllamaApiHost, formatAzureOpenAIApiHost) are moved to packages/shared/aiCore/provider/utils/api.ts
• CLAUDE_SUPPORTED_PROVIDERS / CLAUDE_OFFICIAL_SUPPORTED_PROVIDERS constants are moved to packages/shared/config/providers.ts
• A main-process version of formatProviderApiHost is created at src/main/aiCore/provider/providerConfig.ts
• The API server now formats provider API hosts before caching/using them, fixing 404 errors caused by unformatted URLs

Fixes #13192

Why we need it and why it was done in this way

The following tradeoffs were made:

• A separate formatProviderApiHost implementation exists in the main process (src/main/aiCore/provider/providerConfig.ts) alongside the renderer version. This is because the Vertex API host formatter in the renderer depends on the Redux store directly, while the main process version uses reduxService. A // WARNING comment is added to remind developers to keep them in sync.
• Renderer-side modules re-export from shared for backward compatibility, avoiding a large-scale import path migration across the codebase.

The following alternatives were considered:

• Fully unifying the renderer and main process formatProviderApiHost was considered but deferred due to the Vertex provider's dependency on different store access patterns ([Bug]: VertexAI Provider Data Storage Architecture Flaw - Type Mismatch with Actual Storage #13194).

Breaking changes

None. All existing renderer imports continue to work via re-exports.

Special notes for your reviewer

• The core bug fix is in src/main/apiServer/utils/index.ts — providers are now formatted via formatProviderApiHost() before being cached.
• Most of the diff is moving code from renderer to shared packages with no logic changes.
• The Revert "refactor: Add const assertions to provider arrays" commit reverts an earlier attempt that caused issues.

Checklist

• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Documentation: A user-guide update was considered and is present (link) or not required. Check this only when the PR introduces or changes a user-facing feature or behavior.
• Self-review: I have reviewed my own code (e.g., via /gh-pr-review, gh pr diff, or GitHub UI) before requesting review from others

Release note

NONE

[EurFelux]

Note

This issue/comment/review was translated by Claude.

Self Review Fixes (b9f8d920c)

Performed a self review of this branch and identified and fixed 3 issues:

1. Promise.allSettled Silently Losing Providers (Medium Severity)

File: src/main/apiServer/utils/index.ts

Previously, getAvailableProviders() used Promise.allSettled + .filter(fulfilled). If formatProviderApiHost threw an exception for a provider, that provider would silently disappear without any error logs.

Fix: Changed to iterate through results and use logger.warn to output the providerId and failure reason for rejected results.

2. Direct Internal Module Path Imports (Code Style)

File: src/renderer/src/utils/api.ts

import { withoutTrailingSlash } from '@shared/utils/api/utils' directly referenced an internal implementation file, exposing the module's internal structure.

Fix: Changed to import from the public entry point @shared/utils.

3. Inconsistent Re-export Paths (Code Cleanliness)

File: src/renderer/src/utils/provider.ts

Re-exports used @shared/aiCore/provider/utils/types, while imports in the same file used @shared/aiCore/provider/utils, creating inconsistent paths.

Fix: Unified to use @shared/aiCore/provider/utils.

---

Original Content

Self Review 修复 (b9f8d920c)

对本分支进行了 self review，发现并修复了 3 个问题：

1. Promise.allSettled 静默丢失 provider（中等严重）

文件: src/main/apiServer/utils/index.ts

之前 getAvailableProviders() 中使用 Promise.allSettled + .filter(fulfilled) 的写法，如果 formatProviderApiHost 对某个 provider 抛出异常，该 provider 会静默消失，没有任何错误日志。

修复: 改为遍历 results，对 rejected 的结果用 logger.warn 输出 providerId 和失败原因。

2. 内部模块路径直接引用（代码规范）

文件: src/renderer/src/utils/api.ts

import { withoutTrailingSlash } from '@shared/utils/api/utils' 直接引用了内部实现文件，暴露了模块内部结构。

修复: 改为从公共入口 @shared/utils 导入。

3. re-export 路径不一致（代码洁净度）

文件: src/renderer/src/utils/provider.ts

re-export 使用 @shared/aiCore/provider/utils/types，而同文件 import 使用 @shared/aiCore/provider/utils，路径不一致。

修复: 统一使用 @shared/aiCore/provider/utils。

[DeJeune]

Overall Assessment

Good PR that addresses a real bug — the API server was using raw provider apiHost values without formatting, causing 404s. The fix in src/main/apiServer/utils/index.ts is clean and well-structured with proper error handling via Promise.allSettled.

The bulk of the diff is a mechanical move of shared utilities from renderer to packages/shared/, which is a sound architectural decision. Tests are comprehensive and CI is green.

Findings

Significant

• Dual formatProviderApiHost sync risk: The main-process and renderer versions have subtle differences (async vs sync, different formatVertexApiHost signatures). The WARNING comment on the renderer side points to the wrong file path (shared/ instead of src/main/). Consider adding a bidirectional WARNING so the sync obligation is visible from both files.

Minor

• Variable shadowing (host) in formatVertexApiHost
• Loose equality (==) instead of strict (===) for string comparison
• Unrelated uuid import change in settings.ts
• Surprising test expectations in formatOllamaApiHost could use explanatory comments

Positives

• Excellent test coverage for the moved utilities
• Promise.allSettled usage in the core fix gracefully handles per-provider formatting failures
• Re-exports for backward compatibility is a pragmatic approach
• PR description is thorough with clear explanation of tradeoffs

[DeJeune]

Nit: Variable host on line 10 shadows the function parameter host on line 3. Consider renaming it to baseHost or vertexHost to avoid confusion.

Suggested change

	projectId: string
	location: string
	const trimmedHost = withoutTrailingSlash(trim(host))
	if (\!trimmedHost || trimmedHost.endsWith('aiplatform.googleapis.com')) {
	const baseHost =
	location == 'global' ? 'https://aiplatform.googleapis.com' : `https://${location}-aiplatform.googleapis.com`
	return `${formatApiHost(baseHost)}/projects/${project}/locations/${location}`

[EurFelux]

renamed to fallbackHost

[DeJeune]

Nit: This import change from @renderer/utils to uuid directly appears unrelated to the PR's scope (API host formatting / shared utility refactor). Was this intentional or a leftover from another change? If intentional, it might be worth mentioning in the PR description.

[EurFelux]

Note

This comment was translated by Claude.

Because if we don't make this change, test errors will occur. The uuid imported from renderer/utils is undefined at runtime, likely caused by circular dependencies in the complex dependency chain. Since it's too difficult to troubleshoot, here we directly changed to use the uuid package, and the runtime behavior remains unchanged.

---

Original Content

因为若不更改就会出现测试错误，从renderer/utils中导入的uuid在运行时为undefined，估计是在复杂的依赖链中出现循环依赖导致的。由于过于难以排查，这里直接改成使用uuid包，运行时行为不变。

[DeJeune]

Significant: This main-process formatProviderApiHost is a near-duplicate of the renderer version at src/renderer/src/aiCore/provider/providerConfig.ts:formatProviderApiHost. Having two copies that must be manually kept in sync is fragile. A few differences stand out:

1. This version is async (returns Promise<Provider>) because of Vertex, while the renderer version is sync.
2. The renderer version uses formatVertexApiHost(formatted) (passing the full provider), while this version uses formatVertexApiHost(formatted.apiHost) (passing just the string). These are actually different functions with different signatures.

Consider adding a corresponding WARNING comment here pointing back to the renderer version, so the sync obligation is visible from both sides.

[EurFelux]

comment added

[DeJeune]

Note

This issue/comment/review was translated by Claude.

Looks like there's some overlap with #11495. Once that merges, I can reduce the code size in this PR.

---

Original Content

看起来和 #11495 有一部分是重合的，这样合并之后，我这个pr就可以少点代码量了

[EurFelux]

Will resolve conflicts later

[GeorgeDong32]

代码审查完成。核心 bug 修复（API server 格式化 provider API hosts）实现正确，测试覆盖完善。存在两处formatProviderApiHost 实现需要手动同步（已有 WARNING 注释），以及小的代码一致性问题（可选改进）。整体质量良好，可以合并。