fix: support http(s) multiaddr with no tcp port #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
|
Manual test of manuel-check succeeds: zinnia run manual-check.js
Calling Filecoin JSON-RPC to get PeerId of miner f03303347
Found peer id: 12D3KooWJ91c6xQshrNe7QAXPFAaeRrHWq2UrgXGPf8UmMZMwyZ5
Querying IPNI to find retrieval providers for bafyreiaxqptvdcxmyiwhb5kpvkmaxv5e3svniomf6ptvxvl7ypnmlrs22a
IPNI returned 4 provider results
Fetching: https://f03303347-market.duckdns.org/ipfs/bafyreiaxqptvdcxmyiwhb5kpvkmaxv5e3svniomf6ptvxvl7ypnmlrs22a?dag-scope=block
Testing HEAD request: https://f03303347-market.duckdns.org/ipfs/bafyreiaxqptvdcxmyiwhb5kpvkmaxv5e3svniomf6ptvxvl7ypnmlrs22a?dag-scope=block
Measurement: {
cid: "bafyreiaxqptvdcxmyiwhb5kpvkmaxv5e3svniomf6ptvxvl7ypnmlrs22a",
minerId: "f03303347",
indexerResult: "OK",
statusCode: 200,
byteLength: 303,
providerId: "12D3KooWJ91c6xQshrNe7QAXPFAaeRrHWq2UrgXGPf8UmMZMwyZ5",
protocol: "http",
providerAddress: "/dns/f03303347-market.duckdns.org/https",
startAt: 2025-03-13T16:54:58.530Z,
carChecksum: "1220d6337701df29192f0112e16220fa829b683ec87e3ad76d46bf938c31a472ac26",
endAt: 2025-03-13T16:55:00.198Z,
headStatusCode: 405
} |
NikolasHaimerl
changed the base branch from
main
to
nhaimerl-smart-contract-support
NikolasHaimerl
changed the title
|
@NikolasHaimerl,Hi buddy, If I want to test it with "Zinnia run manual-check.js," I just need to modify the minerID and peerID in manual-check.js. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing multiaddresses in the direct DNS + HTTP(S) format, which doesn't include a TCP port segment.
Previously, our multiaddr parser could handled addresses with dns following the
/dns/hostname/tcp/port/http(s)pattern, but we encountered addresses in the wild using the more concise format:/dns/hostname/http(s). The current implementation would throw an "unsupported protocol" error when encountering these valid addresses.Changes
Examples of newly supported formats:
Testing
All existing tests continue to pass, and new tests for the direct DNS format were added to verify the implementation. I've also manually verified that the updated parser correctly handles the problematic provider multiaddress that was failing in production.
Related Issues
CheckerNetwork/roadmap#250
Closes #121