-
Notifications
You must be signed in to change notification settings - Fork 1
feat: indexer support for cbor encoding #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: indexer support for cbor encoding #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
…github.com/CheckerNetwork/piece-indexer into nhaimerl-indexer-support-for-cbor-encoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 💪🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the new version without @ts-ignore
s 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I meant to approve the pull request.)
Add support for DAG-CBOR encoded entries
This PR adds support for DAG-CBOR encoded entries (CIDs starting with "bafy", codec 0x71) in addition to the existing DAG-JSON format. This enables the piece-indexer to process advertisements from providers like Curio that use DAG-CBOR encoding.
The implementation:
Closes #119
Implementation Plan: #119 (comment)
Parent Issue: #132